From: Keith Busch <kbusch@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] nvmet: re-fix tracing strncpy() warning
Date: Fri, 5 Jan 2024 13:24:43 -0700 [thread overview]
Message-ID: <ZZhli2FWXwP1XSRG@kbusch-mbp> (raw)
In-Reply-To: <20240103155702.4045835-1-arnd@kernel.org>
On Wed, Jan 03, 2024 at 04:56:55PM +0100, Arnd Bergmann wrote:
> @@ -53,8 +53,7 @@ static inline void __assign_req_name(char *name, struct nvmet_req *req)
> return;
> }
>
> - strncpy(name, req->ns->device_path,
> - min_t(size_t, DISK_NAME_LEN, strlen(req->ns->device_path)));
> + strscpy_pad(name, req->ns->device_path, DISK_NAME_LEN);
> }
I like this one, however Daniel has a different fix for this already
staged in nvme-6.8:
https://git.infradead.org/nvme.git/commitdiff/8f6c0eec5fad13785fd53a5b3b5f8b97b722a2a3
next prev parent reply other threads:[~2024-01-05 20:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 15:56 [PATCH 1/2] nvmet: re-fix tracing strncpy() warning Arnd Bergmann
2024-01-03 15:56 ` [PATCH 2/2] nvme: trace: avoid memcpy overflow warning Arnd Bergmann
2024-01-05 4:31 ` Christoph Hellwig
2024-01-05 20:25 ` Keith Busch
2024-01-05 20:24 ` Keith Busch [this message]
2024-01-05 20:36 ` [PATCH 1/2] nvmet: re-fix tracing strncpy() warning Arnd Bergmann
2024-01-05 20:57 ` Keith Busch
2024-01-05 21:40 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZhli2FWXwP1XSRG@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=hch@lst.de \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox