From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Petre Rodan <petre.rodan@subdimension.ro>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Andreas Klinger <ak@it-klinger.de>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Angel Iglesias <ang.iglesiasg@gmail.com>,
Matti Vaittinen <mazziesaccount@gmail.com>
Subject: Re: [PATCH v3 10/10] iio: pressure: mprls0025pa add SPI driver
Date: Sat, 6 Jan 2024 18:07:55 +0200 [thread overview]
Message-ID: <ZZl628UdGQ_Bu2jy@smile.fi.intel.com> (raw)
In-Reply-To: <ZZl5rBPOKwvxZAAx@sunspire>
On Sat, Jan 06, 2024 at 06:02:52PM +0200, Petre Rodan wrote:
> On Sat, Jan 06, 2024 at 05:30:21PM +0200, Andy Shevchenko wrote:
> > On Fri, Dec 29, 2023 at 11:24:38AM +0200, Petre Rodan wrote:
> > > Add SPI component of the driver.
> > > +#include <linux/mod_devicetable.h>
> > > +#include <linux/module.h>
> > > +#include <linux/spi/spi.h>
> > > +#include <linux/stddef.h>
> >
> > Basically here we need additionally these ones:
> >
> > device.h
> > errno.h
> > types.h
>
> ok, I'll add errno.h. the other two are in the shared .h file.
Yes, but it's better to follow IWYI principle. Generally speaking
there is no guarantee that above will be _always_ the case.
Anyway, I leave this to Jonathan.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-01-06 16:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-29 9:24 [PATCH v3 00/10] changes to mprls0025pa Petre Rodan
2023-12-29 9:24 ` [PATCH v3 01/10] dt-bindings: iio: pressure: honeywell,mprls0025pa.yaml improvements Petre Rodan
2023-12-29 9:24 ` [PATCH v3 02/10] dt-bindings: iio: pressure: honeywell,mprls0025pa.yaml add pressure-triplet Petre Rodan
2024-01-04 8:26 ` Krzysztof Kozlowski
2023-12-29 9:24 ` [PATCH v3 03/10] dt-bindings: iio: pressure: honeywell,mprls0025pa.yaml add spi bus Petre Rodan
2024-01-04 8:26 ` Krzysztof Kozlowski
2023-12-29 9:24 ` [PATCH v3 04/10] iio: pressure: mprls0025pa fix off-by-one enum Petre Rodan
2023-12-29 9:24 ` [PATCH v3 05/10] iio: pressure: mprls0025pa improve driver error resilience Petre Rodan
2023-12-29 9:24 ` [PATCH v3 06/10] iio: pressure: mprls0025pa remove defaults Petre Rodan
2023-12-29 9:24 ` [PATCH v3 07/10] iio: pressure: mprls0025pa whitespace cleanup Petre Rodan
2024-01-06 15:24 ` Andy Shevchenko
2023-12-29 9:24 ` [PATCH v3 08/10] iio: pressure: mprls0025pa refactor Petre Rodan
2023-12-29 9:24 ` [PATCH v3 09/10] iio: pressure: mprls0025pa add triplet property Petre Rodan
2023-12-29 9:24 ` [PATCH v3 10/10] iio: pressure: mprls0025pa add SPI driver Petre Rodan
2024-01-06 15:30 ` Andy Shevchenko
2024-01-06 16:02 ` Petre Rodan
2024-01-06 16:07 ` Andy Shevchenko [this message]
2024-01-07 16:32 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZl628UdGQ_Bu2jy@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=ak@it-klinger.de \
--cc=ang.iglesiasg@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=petre.rodan@subdimension.ro \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox