From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, christophe.jaillet@wanadoo.fr,
David.Laight@aculab.com, ddiss@suse.de, geert@linux-m68k.org
Subject: Re: [PATCH v3 0/4] kstrtox: introduce memparse_safe()
Date: Sat, 6 Jan 2024 16:34:42 +0200 [thread overview]
Message-ID: <ZZllAi_GbsoDF5Eg@smile.fi.intel.com> (raw)
In-Reply-To: <cover.1704324320.git.wqu@suse.com>
On Thu, Jan 04, 2024 at 09:57:47AM +1030, Qu Wenruo wrote:
> [CHANGELOG]
> v3:
> - Fix the 32bit pointer pattern in the test case
> The old pointer pattern for 32 bit systems is in fact 40 bits,
> which would still lead to sparse warning.
> The newer pattern is using UINTPTR_MAX to trim the pattern, then
> converted to a pointer, which should not cause any trimmed bits and
> make sparse happy.
Having test cases is quite good, thanks!
But as I understood what Alexey wanted, is not using the kstrtox files for this.
You can introduce it in the cmdline.c, correct? Just include local "kstrtox.h".
I'm on leave till end of the month, I'll look at this later.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-01-06 14:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 23:27 [PATCH v3 0/4] kstrtox: introduce memparse_safe() Qu Wenruo
2024-01-03 23:27 ` [PATCH v3 1/4] kstrtox: always skip the leading "0x" even if no more valid chars Qu Wenruo
2024-01-03 23:27 ` [PATCH v3 2/4] kstrtox: introduce a safer version of memparse() Qu Wenruo
2024-01-04 6:30 ` Randy Dunlap
2024-01-04 6:42 ` Qu Wenruo
2024-01-04 6:50 ` Randy Dunlap
2024-01-04 6:55 ` Qu Wenruo
2024-01-03 23:27 ` [PATCH v3 3/4] kstrtox: add unit tests for memparse_safe() Qu Wenruo
2024-01-03 23:27 ` [PATCH v3 4/4] btrfs: migrate to the newer memparse_safe() helper Qu Wenruo
2024-01-06 14:34 ` Andy Shevchenko [this message]
2024-01-06 20:58 ` [PATCH v3 0/4] kstrtox: introduce memparse_safe() Qu Wenruo
2024-01-14 13:42 ` Andy Shevchenko
2024-01-14 20:01 ` Qu Wenruo
-- strict thread matches above, loose matches on Subject: below --
2024-02-01 15:18 Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZllAi_GbsoDF5Eg@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=David.Laight@aculab.com \
--cc=akpm@linux-foundation.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=ddiss@suse.de \
--cc=geert@linux-m68k.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox