drivers/mux/adg792a.c:134:34: warning: 'adg792a_of

public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed

* drivers/mux/adg792a.c:134:34: warning: 'adg792a_of_match' defined but not used
@ 2023-12-28 18:46 kernel test robot
  2024-01-06 15:04 ` Andy Shevchenko
  0 siblings, 1 reply; 14+ messages in thread
From: kernel test robot @ 2023-12-28 18:46 UTC (permalink / raw)
  To: Andy Shevchenko; +Cc: oe-kbuild-all, linux-kernel, Jonathan Cameron

Hi Andy,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   f5837722ffecbbedf1b1dbab072a063565f0dad1
commit: 879a52379704e479237d0b97822fd9302fed0675 iio: multiplexer: Make use of device properties
date:   1 year, 9 months ago
config: x86_64-randconfig-016-20230827 (https://download.01.org/0day-ci/archive/20231229/202312290237.ChqMrE6k-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231229/202312290237.ChqMrE6k-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312290237.ChqMrE6k-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/mux/adg792a.c:134:34: warning: 'adg792a_of_match' defined but not used [-Wunused-const-variable=]
     134 | static const struct of_device_id adg792a_of_match[] = {
         |                                  ^~~~~~~~~~~~~~~~


vim +/adg792a_of_match +134 drivers/mux/adg792a.c

afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  133  
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14 @134  static const struct of_device_id adg792a_of_match[] = {
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  135  	{ .compatible = "adi,adg792a", },
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  136  	{ .compatible = "adi,adg792g", },
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  137  	{ }
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  138  };
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  139  MODULE_DEVICE_TABLE(of, adg792a_of_match);
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  140  

:::::: The code at line 134 was first introduced by commit
:::::: afda08c4caa9489511557def51e322a5f2142a2f mux: adg792a: add mux controller driver for ADG792A/G

:::::: TO: Peter Rosin <peda@axentia.se>
:::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: drivers/mux/adg792a.c:134:34: warning: 'adg792a_of_match' defined but not used
  2023-12-28 18:46 drivers/mux/adg792a.c:134:34: warning: 'adg792a_of_match' defined but not used kernel test robot
@ 2024-01-06 15:04 ` Andy Shevchenko
  0 siblings, 0 replies; 14+ messages in thread
From: Andy Shevchenko @ 2024-01-06 15:04 UTC (permalink / raw)
  To: kernel test robot; +Cc: oe-kbuild-all, linux-kernel, Jonathan Cameron

On Fri, Dec 29, 2023 at 02:46:30AM +0800, kernel test robot wrote:
> Hi Andy,

...

> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202312290237.ChqMrE6k-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
> >> drivers/mux/adg792a.c:134:34: warning: 'adg792a_of_match' defined but not used [-Wunused-const-variable=]
>      134 | static const struct of_device_id adg792a_of_match[] = {
>          |                                  ^~~~~~~~~~~~~~~~

of_match_ptr() should be dropped.

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 14+ messages in thread

* drivers/mux/adg792a.c:134:34: warning: 'adg792a_of_match' defined but not used
@ 2025-01-13  5:08 kernel test robot
  0 siblings, 0 replies; 14+ messages in thread
From: kernel test robot @ 2025-01-13  5:08 UTC (permalink / raw)
  To: Andy Shevchenko; +Cc: oe-kbuild-all, linux-kernel, Jonathan Cameron

Hi Andy,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   5bc55a333a2f7316b58edc7573e8e893f7acb532
commit: 879a52379704e479237d0b97822fd9302fed0675 iio: multiplexer: Make use of device properties
date:   2 years, 9 months ago
config: x86_64-randconfig-122-20240831 (https://download.01.org/0day-ci/archive/20250113/202501131220.hPs8onrh-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250113/202501131220.hPs8onrh-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501131220.hPs8onrh-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/mux/adg792a.c:134:34: warning: 'adg792a_of_match' defined but not used [-Wunused-const-variable=]
     134 | static const struct of_device_id adg792a_of_match[] = {
         |                                  ^~~~~~~~~~~~~~~~


vim +/adg792a_of_match +134 drivers/mux/adg792a.c

afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  133  
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14 @134  static const struct of_device_id adg792a_of_match[] = {
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  135  	{ .compatible = "adi,adg792a", },
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  136  	{ .compatible = "adi,adg792g", },
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  137  	{ }
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  138  };
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  139  MODULE_DEVICE_TABLE(of, adg792a_of_match);
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  140  

:::::: The code at line 134 was first introduced by commit
:::::: afda08c4caa9489511557def51e322a5f2142a2f mux: adg792a: add mux controller driver for ADG792A/G

:::::: TO: Peter Rosin <peda@axentia.se>
:::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 14+ messages in thread

* drivers/mux/adg792a.c:134:34: warning: 'adg792a_of_match' defined but not used
@ 2025-01-06  8:54 kernel test robot
  0 siblings, 0 replies; 14+ messages in thread
From: kernel test robot @ 2025-01-06  8:54 UTC (permalink / raw)
  To: Aswath Govindraju; +Cc: oe-kbuild-all, linux-kernel, Vinod Koul

Hi Aswath,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   9d89551994a430b50c4fffcb1e617a057fa76e20
commit: e4d4371253029528c02bfb43a46c252e1c3d035f phy: phy-can-transceiver: Add support for setting mux
date:   2 years, 9 months ago
config: sh-randconfig-002-20241212 (https://download.01.org/0day-ci/archive/20250106/202501061623.b5Jszq2k-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 12.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250106/202501061623.b5Jszq2k-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501061623.b5Jszq2k-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/mux/adg792a.c:134:34: warning: 'adg792a_of_match' defined but not used [-Wunused-const-variable=]
     134 | static const struct of_device_id adg792a_of_match[] = {
         |                                  ^~~~~~~~~~~~~~~~


vim +/adg792a_of_match +134 drivers/mux/adg792a.c

afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  133  
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14 @134  static const struct of_device_id adg792a_of_match[] = {
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  135  	{ .compatible = "adi,adg792a", },
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  136  	{ .compatible = "adi,adg792g", },
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  137  	{ }
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  138  };
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  139  MODULE_DEVICE_TABLE(of, adg792a_of_match);
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  140  

:::::: The code at line 134 was first introduced by commit
:::::: afda08c4caa9489511557def51e322a5f2142a2f mux: adg792a: add mux controller driver for ADG792A/G

:::::: TO: Peter Rosin <peda@axentia.se>
:::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 14+ messages in thread

* drivers/mux/adg792a.c:134:34: warning: 'adg792a_of_match' defined but not used
@ 2024-01-21 12:13 kernel test robot
  0 siblings, 0 replies; 14+ messages in thread
From: kernel test robot @ 2024-01-21 12:13 UTC (permalink / raw)
  To: Andy Shevchenko; +Cc: oe-kbuild-all, linux-kernel, Jonathan Cameron

Hi Andy,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   7a396820222d6d4c02057f41658b162bdcdadd0e
commit: 879a52379704e479237d0b97822fd9302fed0675 iio: multiplexer: Make use of device properties
date:   1 year, 10 months ago
config: x86_64-randconfig-x063-20230716 (https://download.01.org/0day-ci/archive/20240121/202401212032.jgSOk2Zn-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240121/202401212032.jgSOk2Zn-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401212032.jgSOk2Zn-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/mux/adg792a.c:134:34: warning: 'adg792a_of_match' defined but not used [-Wunused-const-variable=]
     134 | static const struct of_device_id adg792a_of_match[] = {
         |                                  ^~~~~~~~~~~~~~~~

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for DRM_I915_DEBUG_GEM
   Depends on [n]: HAS_IOMEM [=y] && DRM_I915 [=y] && EXPERT [=y] && DRM_I915_WERROR [=n]
   Selected by [y]:
   - DRM_I915_DEBUG [=y] && HAS_IOMEM [=y] && DRM_I915 [=y] && EXPERT [=y] && !COMPILE_TEST [=n]


vim +/adg792a_of_match +134 drivers/mux/adg792a.c

afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  133  
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14 @134  static const struct of_device_id adg792a_of_match[] = {
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  135  	{ .compatible = "adi,adg792a", },
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  136  	{ .compatible = "adi,adg792g", },
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  137  	{ }
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  138  };
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  139  MODULE_DEVICE_TABLE(of, adg792a_of_match);
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  140  

:::::: The code at line 134 was first introduced by commit
:::::: afda08c4caa9489511557def51e322a5f2142a2f mux: adg792a: add mux controller driver for ADG792A/G

:::::: TO: Peter Rosin <peda@axentia.se>
:::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 14+ messages in thread

* drivers/mux/adg792a.c:134:34: warning: 'adg792a_of_match' defined but not used
@ 2023-12-28 14:30 kernel test robot
  0 siblings, 0 replies; 14+ messages in thread
From: kernel test robot @ 2023-12-28 14:30 UTC (permalink / raw)
  To: Aswath Govindraju; +Cc: oe-kbuild-all, linux-kernel, Vinod Koul

Hi Aswath,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   f5837722ffecbbedf1b1dbab072a063565f0dad1
commit: e4d4371253029528c02bfb43a46c252e1c3d035f phy: phy-can-transceiver: Add support for setting mux
date:   1 year, 9 months ago
config: x86_64-randconfig-c022-20230306 (https://download.01.org/0day-ci/archive/20231228/202312282250.c3GseJPc-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231228/202312282250.c3GseJPc-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312282250.c3GseJPc-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/mux/adg792a.c:134:34: warning: 'adg792a_of_match' defined but not used [-Wunused-const-variable=]
     134 | static const struct of_device_id adg792a_of_match[] = {
         |                                  ^~~~~~~~~~~~~~~~


vim +/adg792a_of_match +134 drivers/mux/adg792a.c

afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  133  
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14 @134  static const struct of_device_id adg792a_of_match[] = {
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  135  	{ .compatible = "adi,adg792a", },
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  136  	{ .compatible = "adi,adg792g", },
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  137  	{ }
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  138  };
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  139  MODULE_DEVICE_TABLE(of, adg792a_of_match);
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  140  

:::::: The code at line 134 was first introduced by commit
:::::: afda08c4caa9489511557def51e322a5f2142a2f mux: adg792a: add mux controller driver for ADG792A/G

:::::: TO: Peter Rosin <peda@axentia.se>
:::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 14+ messages in thread

* drivers/mux/adg792a.c:134:34: warning: 'adg792a_of_match' defined but not used
@ 2023-12-04  8:56 kernel test robot
  0 siblings, 0 replies; 14+ messages in thread
From: kernel test robot @ 2023-12-04  8:56 UTC (permalink / raw)
  To: Aswath Govindraju; +Cc: oe-kbuild-all, linux-kernel, Vinod Koul

Hi Aswath,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   33cc938e65a98f1d29d0a18403dbbee050dcad9a
commit: e4d4371253029528c02bfb43a46c252e1c3d035f phy: phy-can-transceiver: Add support for setting mux
date:   1 year, 8 months ago
config: x86_64-buildonly-randconfig-004-20230906 (https://download.01.org/0day-ci/archive/20231204/202312041505.xa4xbjAK-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231204/202312041505.xa4xbjAK-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312041505.xa4xbjAK-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/mux/adg792a.c:134:34: warning: 'adg792a_of_match' defined but not used [-Wunused-const-variable=]
     134 | static const struct of_device_id adg792a_of_match[] = {
         |                                  ^~~~~~~~~~~~~~~~


vim +/adg792a_of_match +134 drivers/mux/adg792a.c

afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  133  
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14 @134  static const struct of_device_id adg792a_of_match[] = {
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  135  	{ .compatible = "adi,adg792a", },
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  136  	{ .compatible = "adi,adg792g", },
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  137  	{ }
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  138  };
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  139  MODULE_DEVICE_TABLE(of, adg792a_of_match);
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  140  

:::::: The code at line 134 was first introduced by commit
:::::: afda08c4caa9489511557def51e322a5f2142a2f mux: adg792a: add mux controller driver for ADG792A/G

:::::: TO: Peter Rosin <peda@axentia.se>
:::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 14+ messages in thread

* drivers/mux/adg792a.c:134:34: warning: 'adg792a_of_match' defined but not used
@ 2023-11-16  6:03 kernel test robot
  0 siblings, 0 replies; 14+ messages in thread
From: kernel test robot @ 2023-11-16  6:03 UTC (permalink / raw)
  To: Aswath Govindraju; +Cc: oe-kbuild-all, linux-kernel, Vinod Koul

Hi Aswath,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   c42d9eeef8e5ba9292eda36fd8e3c11f35ee065c
commit: e4d4371253029528c02bfb43a46c252e1c3d035f phy: phy-can-transceiver: Add support for setting mux
date:   1 year, 7 months ago
config: x86_64-randconfig-x012-20230629 (https://download.01.org/0day-ci/archive/20231116/202311161306.opyfcoCY-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231116/202311161306.opyfcoCY-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311161306.opyfcoCY-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/mux/adg792a.c:134:34: warning: 'adg792a_of_match' defined but not used [-Wunused-const-variable=]
     134 | static const struct of_device_id adg792a_of_match[] = {
         |                                  ^~~~~~~~~~~~~~~~


vim +/adg792a_of_match +134 drivers/mux/adg792a.c

afda08c4caa94895 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  133  
afda08c4caa94895 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14 @134  static const struct of_device_id adg792a_of_match[] = {
afda08c4caa94895 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  135  	{ .compatible = "adi,adg792a", },
afda08c4caa94895 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  136  	{ .compatible = "adi,adg792g", },
afda08c4caa94895 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  137  	{ }
afda08c4caa94895 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  138  };
afda08c4caa94895 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  139  MODULE_DEVICE_TABLE(of, adg792a_of_match);
afda08c4caa94895 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  140  

:::::: The code at line 134 was first introduced by commit
:::::: afda08c4caa9489511557def51e322a5f2142a2f mux: adg792a: add mux controller driver for ADG792A/G

:::::: TO: Peter Rosin <peda@axentia.se>
:::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 14+ messages in thread

* drivers/mux/adg792a.c:134:34: warning: 'adg792a_of_match' defined but not used
@ 2023-11-05  5:02 kernel test robot
  2023-11-05 20:08 ` Chris Packham
                   ` (2 more replies)
  0 siblings, 3 replies; 14+ messages in thread
From: kernel test robot @ 2023-11-05  5:02 UTC (permalink / raw)
  To: Chris Packham; +Cc: oe-kbuild-all, linux-kernel, Mark Brown, Andy Shevchenko

Hi Chris,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   aea6bf908d730b01bd264a8821159db9463c111c
commit: e9e40543ad5b38b848879768359fd13650529961 spi: Add generic SPI multiplexer
date:   3 years, 9 months ago
config: i386-randconfig-004-20231101 (https://download.01.org/0day-ci/archive/20231105/202311051347.7J6bthD7-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231105/202311051347.7J6bthD7-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311051347.7J6bthD7-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/mux/adg792a.c:134:34: warning: 'adg792a_of_match' defined but not used [-Wunused-const-variable=]
     134 | static const struct of_device_id adg792a_of_match[] = {
         |                                  ^~~~~~~~~~~~~~~~


vim +/adg792a_of_match +134 drivers/mux/adg792a.c

afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  133  
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14 @134  static const struct of_device_id adg792a_of_match[] = {
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  135  	{ .compatible = "adi,adg792a", },
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  136  	{ .compatible = "adi,adg792g", },
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  137  	{ }
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  138  };
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  139  MODULE_DEVICE_TABLE(of, adg792a_of_match);
afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  140  

:::::: The code at line 134 was first introduced by commit
:::::: afda08c4caa9489511557def51e322a5f2142a2f mux: adg792a: add mux controller driver for ADG792A/G

:::::: TO: Peter Rosin <peda@axentia.se>
:::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: drivers/mux/adg792a.c:134:34: warning: 'adg792a_of_match' defined but not used
  2023-11-05  5:02 kernel test robot
@ 2023-11-05 20:08 ` Chris Packham
  2023-11-06 18:07 ` Andy Shevchenko
       [not found] ` <CAHp75VfmUXgx3nkFR=dZqffOu-LSnU_9u9GRYy0bTPLcdYhHbg@mail.gmail.com>
  2 siblings, 0 replies; 14+ messages in thread
From: Chris Packham @ 2023-11-05 20:08 UTC (permalink / raw)
  To: kernel test robot
  Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
	Mark Brown, Andy Shevchenko


On 5/11/23 18:02, kernel test robot wrote:
> Hi Chris,
>
> First bad commit (maybe != root cause):
>
> tree:   https://scanmail.trustwave.com/?c=20988&d=s6LH5Y7HiCJ1b6-4oP--FMP_NIoKokMD3iOna8wtMw&u=https%3a%2f%2fgit%2ekernel%2eorg%2fpub%2fscm%2flinux%2fkernel%2fgit%2ftorvalds%2flinux%2egit master
> head:   aea6bf908d730b01bd264a8821159db9463c111c
> commit: e9e40543ad5b38b848879768359fd13650529961 spi: Add generic SPI multiplexer
> date:   3 years, 9 months ago
> config: i386-randconfig-004-20231101 (https://scanmail.trustwave.com/?c=20988&d=s6LH5Y7HiCJ1b6-4oP--FMP_NIoKokMD3nOja5wtNg&u=https%3a%2f%2fdownload%2e01%2eorg%2f0day-ci%2farchive%2f20231105%2f202311051347%2e7J6bthD7-lkp%40intel%2ecom%2fconfig)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build): (https://scanmail.trustwave.com/?c=20988&d=s6LH5Y7HiCJ1b6-4oP--FMP_NIoKokMD3nGlbZkuYA&u=https%3a%2f%2fdownload%2e01%2eorg%2f0day-ci%2farchive%2f20231105%2f202311051347%2e7J6bthD7-lkp%40intel%2ecom%2freproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://scanmail.trustwave.com/?c=20988&d=s6LH5Y7HiCJ1b6-4oP--FMP_NIoKokMD3imkZ8ssZQ&u=https%3a%2f%2flore%2ekernel%2eorg%2foe-kbuild-all%2f202311051347%2e7J6bthD7-lkp%40intel%2ecom%2f
>
> All warnings (new ones prefixed by >>):
>
>>> drivers/mux/adg792a.c:134:34: warning: 'adg792a_of_match' defined but not used [-Wunused-const-variable=]
>       134 | static const struct of_device_id adg792a_of_match[] = {
>           |                                  ^~~~~~~~~~~~~~~~
>
>
> vim +/adg792a_of_match +134 drivers/mux/adg792a.c
>
> afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  133
> afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14 @134  static const struct of_device_id adg792a_of_match[] = {
> afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  135  	{ .compatible = "adi,adg792a", },
> afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  136  	{ .compatible = "adi,adg792g", },
> afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  137  	{ }
> afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  138  };
> afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  139  MODULE_DEVICE_TABLE(of, adg792a_of_match);
> afda08c4caa948 drivers/mux/mux-adg792a.c Peter Rosin 2017-05-14  140
>
> :::::: The code at line 134 was first introduced by commit
> :::::: afda08c4caa9489511557def51e322a5f2142a2f mux: adg792a: add mux controller driver for ADG792A/G
>
> :::::: TO: Peter Rosin <peda@axentia.se>
> :::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

I'm gonna go ahead and plead innocent on this one.

>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: drivers/mux/adg792a.c:134:34: warning: 'adg792a_of_match' defined but not used
  2023-11-05  5:02 kernel test robot
  2023-11-05 20:08 ` Chris Packham
@ 2023-11-06 18:07 ` Andy Shevchenko
       [not found] ` <CAHp75VfmUXgx3nkFR=dZqffOu-LSnU_9u9GRYy0bTPLcdYhHbg@mail.gmail.com>
  2 siblings, 0 replies; 14+ messages in thread
From: Andy Shevchenko @ 2023-11-06 18:07 UTC (permalink / raw)
  To: kernel test robot, Peter Rosin
  Cc: Chris Packham, oe-kbuild-all, linux-kernel, Mark Brown

(Resend to all)

On Sun, Nov 5, 2023 at 7:03 AM kernel test robot <lkp@intel.com> wrote:
>
> Hi Chris,
>
> First bad commit (maybe != root cause):

Indeed.

>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   aea6bf908d730b01bd264a8821159db9463c111c
> commit: e9e40543ad5b38b848879768359fd13650529961 spi: Add generic SPI multiplexer
> date:   3 years, 9 months ago
> config: i386-randconfig-004-20231101 (https://download.01.org/0day-ci/archive/20231105/202311051347.7J6bthD7-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231105/202311051347.7J6bthD7-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202311051347.7J6bthD7-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
> >> drivers/mux/adg792a.c:134:34: warning: 'adg792a_of_match' defined but not used [-Wunused-const-variable=]
>      134 | static const struct of_device_id adg792a_of_match[] = {
>          |                                  ^~~~~~~~~~~~~~~~
>

I dunno why it's pointing out to that commit and some (random?) people
in Cc list, but the real problem there from day 1, i.e. (ab)using
of_match_ptr(). The of_match_ptr() should not ever be used. It appears
more harmful than useful.

Hence the proper fix is to drop of_match_ptr() in this file.


> vim +/adg792a_of_match +134 drivers/mux/adg792a.c

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 14+ messages in thread

[parent not found: <CAHp75VfmUXgx3nkFR=dZqffOu-LSnU_9u9GRYy0bTPLcdYhHbg@mail.gmail.com>]

[parent not found: <ZUdFtJeXBtx/httL@rli9-mobl>]

[parent not found: <abdb00c4-c2f1-96e6-9731-5a1773099336@axentia.se>]

* Re: drivers/mux/adg792a.c:134:34: warning: 'adg792a_of_match' defined but not used
       [not found]     ` <abdb00c4-c2f1-96e6-9731-5a1773099336@axentia.se>
@ 2023-11-07 19:59       ` Andy Shevchenko
  2023-11-07 21:39         ` Peter Rosin
  0 siblings, 1 reply; 14+ messages in thread
From: Andy Shevchenko @ 2023-11-07 19:59 UTC (permalink / raw)
  To: Peter Rosin
  Cc: Philip Li, kernel test robot, Chris Packham, oe-kbuild-all,
	Linux Kernel Mailing List, Mark Brown

On Mon, Nov 6, 2023 at 11:31 PM Peter Rosin <peda@axentia.se> wrote:
> 2023-11-05 at 08:35, Philip Li wrote:
> > On Sun, Nov 05, 2023 at 09:09:00AM +0200, Andy Shevchenko wrote:
> >> On Sun, Nov 5, 2023 at 7:03 AM kernel test robot <lkp@intel.com> wrote:
> >>> commit: e9e40543ad5b38b848879768359fd13650529961 spi: Add generic SPI multiplexer

...

> >> I dunno why it's pointing out to that commit and some (random?) people
> >
> > Sorry for the incorrect bad commit, Andy. We will investigate this why
> > it locates to this commit in the bisection process, and try to avoid
> > similar wrong report if possible.
>
> In this case I think the reason is that you have CONFIG_SPI_MUX, which
> seletcs CONFIG_MULTIPLEXER, which in turn makes CONFIG_MUX_ADG792A
> "visible". I.e. before the fingered commit, it is likely that nothing
> selects CONFIG_MULTIPLEXER with the given configuration.

The use of the of_match_ptr() is quite doubtful, no?

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: drivers/mux/adg792a.c:134:34: warning: 'adg792a_of_match' defined but not used
  2023-11-07 19:59       ` Andy Shevchenko
@ 2023-11-07 21:39         ` Peter Rosin
  2023-11-09 13:59           ` Andy Shevchenko
  0 siblings, 1 reply; 14+ messages in thread
From: Peter Rosin @ 2023-11-07 21:39 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: Philip Li, kernel test robot, Chris Packham, oe-kbuild-all,
	Linux Kernel Mailing List, Mark Brown



2023-11-07 at 20:59, Andy Shevchenko wrote:
> On Mon, Nov 6, 2023 at 11:31 PM Peter Rosin <peda@axentia.se> wrote:
>> 2023-11-05 at 08:35, Philip Li wrote:
>>> On Sun, Nov 05, 2023 at 09:09:00AM +0200, Andy Shevchenko wrote:
>>>> On Sun, Nov 5, 2023 at 7:03 AM kernel test robot <lkp@intel.com> wrote:
>>>>> commit: e9e40543ad5b38b848879768359fd13650529961 spi: Add generic SPI multiplexer
> 
> ...
> 
>>>> I dunno why it's pointing out to that commit and some (random?) people
>>>
>>> Sorry for the incorrect bad commit, Andy. We will investigate this why
>>> it locates to this commit in the bisection process, and try to avoid
>>> similar wrong report if possible.
>>
>> In this case I think the reason is that you have CONFIG_SPI_MUX, which
>> seletcs CONFIG_MULTIPLEXER, which in turn makes CONFIG_MUX_ADG792A
>> "visible". I.e. before the fingered commit, it is likely that nothing
>> selects CONFIG_MULTIPLEXER with the given configuration.
> 
> The use of the of_match_ptr() is quite doubtful, no?

I was trying to answer why the spi-mux addition was (wrongly) fingered as
the first bad commit. I should have been clearer...

I don't see what's wrong with using of_match_ptr() in this driver as
CONFIG_OF is not required here. Why isn't the correct fix to instead
put the definition of adg792a_of_match in an #ifdef CONFIG_OF block?

Cheers,
Peter

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: drivers/mux/adg792a.c:134:34: warning: 'adg792a_of_match' defined but not used
  2023-11-07 21:39         ` Peter Rosin
@ 2023-11-09 13:59           ` Andy Shevchenko
  0 siblings, 0 replies; 14+ messages in thread
From: Andy Shevchenko @ 2023-11-09 13:59 UTC (permalink / raw)
  To: Peter Rosin, Arnd Bergmann
  Cc: Philip Li, kernel test robot, Chris Packham, oe-kbuild-all,
	Linux Kernel Mailing List, Mark Brown

On Tue, Nov 7, 2023 at 11:39 PM Peter Rosin <peda@axentia.se> wrote:
> 2023-11-07 at 20:59, Andy Shevchenko wrote:
> > On Mon, Nov 6, 2023 at 11:31 PM Peter Rosin <peda@axentia.se> wrote:

...

> > The use of the of_match_ptr() is quite doubtful, no?
>
> I was trying to answer why the spi-mux addition was (wrongly) fingered as
> the first bad commit. I should have been clearer...
>
> I don't see what's wrong with using of_match_ptr() in this driver as
> CONFIG_OF is not required here. Why isn't the correct fix to instead
> put the definition of adg792a_of_match in an #ifdef CONFIG_OF block?

Because:
- it is prone to error (as evidence this report)
- it adds ugly ifdeffery and more LoCs in the code for no value
- it prevents driver to be used in ACPI

I found at least two of these arguments are serious enough to drop
that macro and not use it _at all_ generally speaking.

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2025-01-13  5:08 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-28 18:46 drivers/mux/adg792a.c:134:34: warning: 'adg792a_of_match' defined but not used kernel test robot
2024-01-06 15:04 ` Andy Shevchenko
  -- strict thread matches above, loose matches on Subject: below --
2025-01-13  5:08 kernel test robot
2025-01-06  8:54 kernel test robot
2024-01-21 12:13 kernel test robot
2023-12-28 14:30 kernel test robot
2023-12-04  8:56 kernel test robot
2023-11-16  6:03 kernel test robot
2023-11-05  5:02 kernel test robot
2023-11-05 20:08 ` Chris Packham
2023-11-06 18:07 ` Andy Shevchenko
     [not found] ` <CAHp75VfmUXgx3nkFR=dZqffOu-LSnU_9u9GRYy0bTPLcdYhHbg@mail.gmail.com>
     [not found]   ` <ZUdFtJeXBtx/httL@rli9-mobl>
     [not found]     ` <abdb00c4-c2f1-96e6-9731-5a1773099336@axentia.se>
2023-11-07 19:59       ` Andy Shevchenko
2023-11-07 21:39         ` Peter Rosin
2023-11-09 13:59           ` Andy Shevchenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox