From: Boqun Feng <boqun.feng@gmail.com>
To: Xuewen Yan <xuewen.yan94@gmail.com>
Cc: Xuewen Yan <xuewen.yan@unisoc.com>,
peterz@infradead.org, mingo@redhat.com, will@kernel.org,
longman@redhat.com, ke.wang@unisoc.com, zhiguo.niu@unisoc.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lock/lockdep: Add missing graph_unlock in validate_chain
Date: Mon, 8 Jan 2024 08:28:46 -0800 [thread overview]
Message-ID: <ZZwivt2C7-oxuMJS@boqun-archlinux> (raw)
In-Reply-To: <CAB8ipk9+BAFOa_4Dm2hs-bpfmMC_LHkaAb=JUVBq1CChX11wzA@mail.gmail.com>
On Fri, Jan 05, 2024 at 12:46:36PM +0800, Xuewen Yan wrote:
[...]
> >
> > Are you hitting a real issue or this is found by code reading?
>
> Indeed, we hit a real issue:
> One cpu did not call graph_unlock, as a result, caused a deadlock with
> other cpus,
> because any cpu calling raw_spin_lock would get the graph_lock first.
>
Could you share more details about the real issue you hit? For example,
serial log? I asked because although the graph_unlock() makes logical
sense, but that path should really not hit if lockdep works correctly.
Thanks!
Regards,
Boqun
> Thanks!
next prev parent reply other threads:[~2024-01-08 16:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-04 5:40 [PATCH] lock/lockdep: Add missing graph_unlock in validate_chain Xuewen Yan
2024-01-04 19:41 ` Boqun Feng
2024-01-05 4:46 ` Xuewen Yan
2024-01-08 16:28 ` Boqun Feng [this message]
2024-01-09 2:55 ` Xuewen Yan
2024-01-09 5:35 ` Boqun Feng
2024-01-09 6:11 ` Xuewen Yan
2024-01-08 13:53 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZwivt2C7-oxuMJS@boqun-archlinux \
--to=boqun.feng@gmail.com \
--cc=ke.wang@unisoc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
--cc=xuewen.yan94@gmail.com \
--cc=xuewen.yan@unisoc.com \
--cc=zhiguo.niu@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox