From: Andy Shevchenko <andy@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/1] x86: Use resource_set_{range,size}() helpers
Date: Wed, 16 Apr 2025 13:22:21 +0300 [thread overview]
Message-ID: <Z_-E3W8i4EfxdBh3@smile.fi.intel.com> (raw)
In-Reply-To: <20250416101318.7313-1-ilpo.jarvinen@linux.intel.com>
On Wed, Apr 16, 2025 at 01:13:18PM +0300, Ilpo Järvinen wrote:
> Convert open coded resource size calculations to use
> resource_set_{range,size}() helpers.
>
> While at it, use SZ_* for size parameter which makes the intent of code
> more obvious.
...
> + resource_set_range(res, base, 1ULL << (segn_busn_bits + 20));
Then probably
resource_set_range(res, base, BIT_ULL(segn_busn_bits) * SZ_1M);
to follow the same "While at it"?
...
> + resource_set_range(res, 0xC0000, SZ_128K);
> res->flags = IORESOURCE_MEM | IORESOURCE_ROM_SHADOW |
> IORESOURCE_PCI_FIXED;
I'm wondering why not DEFINE_RES_MEM() in such cases?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-04-16 10:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 10:13 [PATCH 1/1] x86: Use resource_set_{range,size}() helpers Ilpo Järvinen
2025-04-16 10:22 ` Andy Shevchenko [this message]
2025-04-16 10:23 ` Andy Shevchenko
2025-04-16 11:53 ` Ilpo Järvinen
2025-04-16 12:03 ` Andy Shevchenko
2025-04-16 12:18 ` Ilpo Järvinen
2025-04-16 15:25 ` Andy Shevchenko
2025-04-18 7:40 ` Ingo Molnar
2025-04-18 15:15 ` Ilpo Järvinen
2025-04-19 14:57 ` Ingo Molnar
2025-04-16 15:05 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_-E3W8i4EfxdBh3@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox