From: Tejun Heo <tj@kernel.org>
To: yangsonghua <jluyangsonghua@gmail.com>
Cc: void@manifault.com, arighi@nvidia.com, changwoo@igalia.com,
linux-kernel@vger.kernel.org, sched-ext@meta.com,
yangsonghua <yangsonghua@lixiang.com>
Subject: Re: [PATCH v1] sched_ext: Improve cross-compilation support in Makefile
Date: Mon, 14 Apr 2025 07:01:22 -1000 [thread overview]
Message-ID: <Z_0_YsO2P4nM7LXM@slm.duckdns.org> (raw)
In-Reply-To: <20250414081436.2574882-1-yangsonghua@lixiang.com>
On Mon, Apr 14, 2025 at 04:14:36PM +0800, yangsonghua wrote:
> Modify the tools/sched_ext/Makefile to better handle cross-compilation
> environments by:
>
> 1. Fix host tools build directory structure by separating obj/ from output
> (HOST_BUILD_DIR now points to $(OBJ_DIR)/host/obj)
> 2. Properly propagate CROSS_COMPILE to libbpf sub-make invocation
> 3. Add missing $(HOST_BPFOBJ) build rule with proper host toolchain flags
> (ARCH=, CROSS_COMPILE=, explicit HOSTCC/HOSTLD)
> 4. Consistently quote $(HOSTCC) in bpftool build rule
> 5. Change LDFLAGS assignment to += to allow external extensions
>
> The changes ensure proper cross-compilation behavior while maintaining
> backward compatibility with native builds. Host tools are now correctly
> built with the host toolchain while target binaries use the cross-toolchain.
>
> Signed-off-by: yangsonghua <yangsonghua@lixiang.com>
Doesn't break native builds at least. I take your words that this improves
cross-builds. Applied to sched_ext/for-6.16.
Thanks.
--
tejun
next prev parent reply other threads:[~2025-04-14 17:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 8:14 [PATCH v1] sched_ext: Improve cross-compilation support in Makefile yangsonghua
2025-04-14 17:01 ` Tejun Heo [this message]
2025-04-15 7:32 ` Eric yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_0_YsO2P4nM7LXM@slm.duckdns.org \
--to=tj@kernel.org \
--cc=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=jluyangsonghua@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sched-ext@meta.com \
--cc=void@manifault.com \
--cc=yangsonghua@lixiang.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox