From: Andrea Righi <arighi@nvidia.com>
To: yangsonghua <jluyangsonghua@gmail.com>
Cc: tj@kernel.org, void@manifault.com, changwoo@igalia.com,
linux-kernel@vger.kernel.org, sched-ext@meta.com,
yangsonghua <yangsonghua@lixiang.com>
Subject: Re: [PATCH v2] tools/sched_ext: Improve cross-compilation support in Makefile
Date: Tue, 15 Apr 2025 08:56:59 +0200 [thread overview]
Message-ID: <Z_4DO9uwfi5G7XwF@gpd3> (raw)
In-Reply-To: <20250415054642.3878839-1-yangsonghua@lixiang.com>
On Tue, Apr 15, 2025 at 01:46:42PM +0800, yangsonghua wrote:
...
> ---
> tools/sched_ext/Makefile | 19 +++++++++++++++----
> 1 file changed, 15 insertions(+), 4 deletions(-)
>
> diff --git a/tools/sched_ext/Makefile b/tools/sched_ext/Makefile
> index ca3815e572d8..eb85f3762a1f 100644
> --- a/tools/sched_ext/Makefile
> +++ b/tools/sched_ext/Makefile
> @@ -62,7 +62,7 @@ BINDIR := $(OUTPUT_DIR)/bin
> BPFOBJ := $(BPFOBJ_DIR)/libbpf.a
> ifneq ($(CROSS_COMPILE),)
> HOST_BUILD_DIR := $(OBJ_DIR)/host
> -HOST_OUTPUT_DIR := host-tools
> +HOST_OUTPUT_DIR := $(OBJ_DIR)/host-tools
> HOST_INCLUDE_DIR := $(HOST_OUTPUT_DIR)/include
> else
> HOST_BUILD_DIR := $(OBJ_DIR)
> @@ -136,14 +136,25 @@ $(MAKE_DIRS):
> $(BPFOBJ): $(wildcard $(BPFDIR)/*.[ch] $(BPFDIR)/Makefile) \
> $(APIDIR)/linux/bpf.h \
> | $(OBJ_DIR)/libbpf
> - $(Q)$(MAKE) $(submake_extras) -C $(BPFDIR) OUTPUT=$(OBJ_DIR)/libbpf/ \
> + $(Q)$(MAKE) $(submake_extras) CROSS_COMPILE=$(CROSS_COMPILE) \
Are we missing ARCH=$(ARCH) here?
Thanks,
-Andrea
> + -C $(BPFDIR) OUTPUT=$(OBJ_DIR)/libbpf/ \
> EXTRA_CFLAGS='-g -O0 -fPIC' \
> + LDFLAGS="$(LDFLAGS)" \
> DESTDIR=$(OUTPUT_DIR) prefix= all install_headers
>
> +$(HOST_BPFOBJ): $(wildcard $(BPFDIR)/*.[ch] $(BPFDIR)/Makefile) \
> + $(APIDIR)/linux/bpf.h \
> + | $(HOST_BUILD_DIR)/libbpf
> + $(Q)$(MAKE) $(submake_extras) -C $(BPFDIR) \
> + OUTPUT=$(HOST_BUILD_DIR)/libbpf/ \
> + ARCH= CROSS_COMPILE= CC="$(HOSTCC)" LD=$(HOSTLD) \
> + EXTRA_CFLAGS='-g -O0 -fPIC' \
> + DESTDIR=$(HOST_OUTPUT_DIR) prefix= all install_headers
> +
> $(DEFAULT_BPFTOOL): $(wildcard $(BPFTOOLDIR)/*.[ch] $(BPFTOOLDIR)/Makefile) \
> $(HOST_BPFOBJ) | $(HOST_BUILD_DIR)/bpftool
> $(Q)$(MAKE) $(submake_extras) -C $(BPFTOOLDIR) \
> - ARCH= CROSS_COMPILE= CC=$(HOSTCC) LD=$(HOSTLD) \
> + ARCH= CROSS_COMPILE= CC="$(HOSTCC)" LD=$(HOSTLD) \
> EXTRA_CFLAGS='-g -O0' \
> OUTPUT=$(HOST_BUILD_DIR)/bpftool/ \
> LIBBPF_OUTPUT=$(HOST_BUILD_DIR)/libbpf/ \
> @@ -185,7 +196,7 @@ $(addprefix $(BINDIR)/,$(c-sched-targets)): \
> $(SCX_COMMON_DEPS)
> $(eval sched=$(notdir $@))
> $(CC) $(CFLAGS) -c $(sched).c -o $(SCXOBJ_DIR)/$(sched).o
> - $(CC) -o $@ $(SCXOBJ_DIR)/$(sched).o $(HOST_BPFOBJ) $(LDFLAGS)
> + $(CC) -o $@ $(SCXOBJ_DIR)/$(sched).o $(BPFOBJ) $(LDFLAGS)
>
> $(c-sched-targets): %: $(BINDIR)/%
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2025-04-15 6:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 5:46 [PATCH v2] tools/sched_ext: Improve cross-compilation support in Makefile yangsonghua
2025-04-15 6:52 ` Andrea Righi
2025-04-15 6:56 ` Andrea Righi [this message]
2025-04-15 14:57 ` Tejun Heo
2025-04-16 1:24 ` Eric yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_4DO9uwfi5G7XwF@gpd3 \
--to=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=jluyangsonghua@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sched-ext@meta.com \
--cc=tj@kernel.org \
--cc=void@manifault.com \
--cc=yangsonghua@lixiang.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox