From: Christoph Hellwig <hch@infradead.org>
To: Lizhi Xu <lizhi.xu@windriver.com>
Cc: hch@infradead.org, almaz.alexandrovich@paragon-software.com,
brauner@kernel.org, jack@suse.cz, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, ntfs3@lists.linux.dev,
syzbot+e36cc3297bd3afd25e19@syzkaller.appspotmail.com,
syzkaller-bugs@googlegroups.com, viro@zeniv.linux.org.uk
Subject: Re: [PATCH V2] fs/ntfs3: Add missing direct_IO in ntfs_aops_cmpr
Date: Tue, 15 Apr 2025 23:05:56 -0700 [thread overview]
Message-ID: <Z_9IxOypdO5Ks44N@infradead.org> (raw)
In-Reply-To: <20250416060351.2971835-1-lizhi.xu@windriver.com>
On Wed, Apr 16, 2025 at 02:03:51PM +0800, Lizhi Xu wrote:
> In the reproducer, the second file passed in by the system call sendfile()
> sets the file flag O_DIRECT when opening the file, which bypasses the page
> cache and accesses the direct io interface of the ntfs3 file system.
> However, ntfs3 does not set direct_IO for compressed files in ntfs_aops_cmpr.
Not allowing direct I/O is perfectly fine. If you think you need to
support direct I/O for this case it is also fine. But none of this
has anything to do with 'can use the page cache' and there are also
plenty of ways to support direct I/O without ->direct_IO.
next prev parent reply other threads:[~2025-04-16 6:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 19:15 [syzbot] [ntfs3?] BUG: unable to handle kernel NULL pointer dereference in generic_file_read_iter syzbot
2025-04-11 0:51 ` [syzbot] " syzbot
2025-04-11 1:24 ` [PATCH] fs/ntfs3: Add missing direct_IO in ntfs_aops_cmpr Lizhi Xu
2025-04-14 5:50 ` Christoph Hellwig
2025-04-15 1:05 ` Lizhi Xu
2025-04-15 9:05 ` Jan Kara
2025-04-15 9:26 ` [PATCH V2] " Lizhi Xu
2025-04-15 11:08 ` Jan Kara
2025-04-16 4:37 ` Christoph Hellwig
2025-04-16 5:34 ` Lizhi Xu
2025-04-16 5:35 ` Christoph Hellwig
2025-04-16 6:03 ` Lizhi Xu
2025-04-16 6:05 ` Christoph Hellwig [this message]
2025-04-16 6:18 ` Lizhi Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_9IxOypdO5Ks44N@infradead.org \
--to=hch@infradead.org \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhi.xu@windriver.com \
--cc=ntfs3@lists.linux.dev \
--cc=syzbot+e36cc3297bd3afd25e19@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox