From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Waiman Long <longman@redhat.com>,
Boqun Feng <boqun.feng@gmail.com>,
Vicentiu Galanopulo <vicentiu.galanopulo@remote-tech.co.uk>,
Will Deacon <will@kernel.org>,
linux-kernel@vger.kernel.org, Bartosz Golaszewski <brgl@bgdev.pl>
Subject: Re: [PATCH v4] locking/mutex: Mark devm_mutex_init() as __must_check
Date: Mon, 7 Apr 2025 11:49:03 +0300 [thread overview]
Message-ID: <Z_ORf1lLqs7UuWY2@smile.fi.intel.com> (raw)
In-Reply-To: <20250407-must_check-devm_mutex_init-v4-1-587bacc9f6b3@weissschuh.net>
On Mon, Apr 07, 2025 at 09:46:47AM +0200, Thomas Weißschuh wrote:
> Even if it's not critical, the avoidance of checking the error code
> from devm_mutex_init() call today diminishes the point of using the devm
> variant of it. Tomorrow it may even leak something. Enforce all callers
> checking the return value through the compiler.
>
> As devm_mutex_init() itself is a macro, it can not be annotated
> directly. Annotate __devm_mutex_init() instead.
> Unfortunately __must_check/warn_unused_result don't propagate through
> statement expression. So move the statement expression into the argument
> list of the call to __devm_mutex_init() through a helper macro.
FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-04-07 8:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 7:46 [PATCH v4] locking/mutex: Mark devm_mutex_init() as __must_check Thomas Weißschuh
2025-04-07 8:49 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_ORf1lLqs7UuWY2@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=boqun.feng@gmail.com \
--cc=brgl@bgdev.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=vicentiu.galanopulo@remote-tech.co.uk \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox