From: Niklas Cassel <cassel@kernel.org>
To: Igor Pylypiv <ipylypiv@google.com>
Cc: Damien Le Moal <dlemoal@kernel.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ata: libata-scsi: Set INFORMATION sense data field consistently
Date: Mon, 7 Apr 2025 10:52:19 +0200 [thread overview]
Message-ID: <Z_OSQzA04-5v7SR0@ryzen> (raw)
In-Reply-To: <Z_AweMPLRJgBIBF3@google.com>
On Fri, Apr 04, 2025 at 12:18:16PM -0700, Igor Pylypiv wrote:
>
> Agree. ATA Status Return sense data descriptor for ATA PASS-THOUGH commands
> already contains the ATA LBA in bytes [6..11] so it seems redundant to
> also include the same in the Information sense data descriptor.
Damien and I talked about this.
Since this patch only affects non-PT commands, what it this patch actually
solving?
Since for non-PT commands, sense data is not returned to the user.
So unless SCSI core does some specific handling based on the INFORMATION
field (and AFAICT, SCSI core only looks at SK/ASC/ASCQ), I can't see how
this patch can actually solve anything.
Kind regards,
Niklas
next prev parent reply other threads:[~2025-04-07 8:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 21:29 [PATCH v2] ata: libata-scsi: Set INFORMATION sense data field consistently Igor Pylypiv
2025-04-04 11:57 ` Niklas Cassel
2025-04-04 19:18 ` Igor Pylypiv
2025-04-07 8:03 ` Niklas Cassel
2025-04-07 9:27 ` Niklas Cassel
2025-04-07 8:52 ` Niklas Cassel [this message]
2025-04-07 18:18 ` Igor Pylypiv
2025-04-07 23:52 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_OSQzA04-5v7SR0@ryzen \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=ipylypiv@google.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox