From: Niklas Cassel <cassel@kernel.org>
To: Igor Pylypiv <ipylypiv@google.com>
Cc: Damien Le Moal <dlemoal@kernel.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ata: libata-scsi: Set INFORMATION sense data field consistently
Date: Mon, 7 Apr 2025 11:27:05 +0200 [thread overview]
Message-ID: <Z_OaafNRHhTiBzFG@ryzen> (raw)
In-Reply-To: <Z_OG6jdsX0_uar2a@ryzen>
On Mon, Apr 07, 2025 at 10:03:54AM +0200, Niklas Cassel wrote:
>
> If we look at the ATA Sense Data for Successful NCQ Commands log,
> it has a bunch of Sense Data descriptors.
>
> ACS-6, 9.29.3 Successful Sense Data descriptor,
> does have the LBA field and an INFORMATION field.
>
> The definition of the INFORMATION field in the Successful Sense Data
> descriptor:
>
> """
> 9.29.3.5 INFORMATION field
> If definition of the sense data to be returned when a command completes
> without an error includes an information value, then the INFORMATION field
> contains the defined value. Otherwise, the INFORMATION field is reserved.
> """
Side note:
Considering that this is just two bytes, and the INFORMATION field in SCSI
is four bytes, I honestly have no idea what this field actually contains.
Anyway, the biggest question is what actual problem this fixes, since the
sense data is not returned to the user for non-passthrough commands.
Kind regards,
Niklas
next prev parent reply other threads:[~2025-04-07 9:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 21:29 [PATCH v2] ata: libata-scsi: Set INFORMATION sense data field consistently Igor Pylypiv
2025-04-04 11:57 ` Niklas Cassel
2025-04-04 19:18 ` Igor Pylypiv
2025-04-07 8:03 ` Niklas Cassel
2025-04-07 9:27 ` Niklas Cassel [this message]
2025-04-07 8:52 ` Niklas Cassel
2025-04-07 18:18 ` Igor Pylypiv
2025-04-07 23:52 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_OaafNRHhTiBzFG@ryzen \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=ipylypiv@google.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox