Re: [PATCH v6 4/4] x86/sev: register tpm-svsm platform device

Borislav Petkov
2025-04-08T11:00:49Z

On Thu, Apr 03, 2025 at 12:09:42PM +0200, Stefano Garzarella wrote:
> @@ -2697,6 +2702,9 @@ static int __init snp_init_platform_device(void)
> if (platform_device_register(&sev_guest_device))
> return -ENODEV;
>
> + if (platform_device_register(&tpm_svsm_device))
> + return -ENODEV;

So I don't understand the design here:

You've exported the probe function - snp_svsm_vtpm_probe() - and you're
calling it in tpm_svsm_probe().

So why aren't you registering the platform device there too but are doing this
unconditional strange thing here?

--
Regards/Gruss,
Boris.