public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: James Morse <james.morse@arm.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
	Tony Luck <tony.luck@intel.com>,
	Reinette Chatre <reinette.chatre@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	babu.moger@amd.com,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [PATCH] x86/resctrl: Fix rdtgroup_mkdir()'s unlocked use of kernfs_node::name
Date: Mon, 7 Apr 2025 20:26:08 +0200	[thread overview]
Message-ID: <Z_QYwMn5dAcTOglC@gmail.com> (raw)
In-Reply-To: <20250407124637.2433230-1-james.morse@arm.com>


* James Morse <james.morse@arm.com> wrote:

> +	/*
> +	 * Check the parent directory for a monitor group is a "mon_groups"
> +	 * directory.
> +	 */

This sentence probably wants to be a bit less linguistically ambiguous, 
via something like:

  s/Check the parent directory for a monitor group is a "mon_groups" directory.
   /Check that the parent directory for a monitor group is a "mon_groups" directory.

With that:

  Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo

  parent reply	other threads:[~2025-04-07 18:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-13 14:50 [PATCH v8 0/6] kernfs: Use RCU to access kernfs_node::{parent|name} Sebastian Andrzej Siewior
2025-02-13 14:50 ` [PATCH v8 1/6] kernfs: Acquire kernfs_rwsem in kernfs_notify_workfn() Sebastian Andrzej Siewior
2025-02-13 14:50 ` [PATCH v8 2/6] kernfs: Acquire kernfs_rwsem in kernfs_get_parent_dentry() Sebastian Andrzej Siewior
2025-02-13 14:50 ` [PATCH v8 3/6] kernfs: Acquire kernfs_rwsem in kernfs_node_dentry() Sebastian Andrzej Siewior
2025-02-13 14:50 ` [PATCH v8 4/6] kernfs: Don't re-lock kernfs_root::kernfs_rwsem in kernfs_fop_readdir() Sebastian Andrzej Siewior
2026-02-23 21:54   ` Zhu, Yi
2025-02-13 14:50 ` [PATCH v8 5/6] kernfs: Use RCU to access kernfs_node::parent Sebastian Andrzej Siewior
2025-02-13 14:50 ` [PATCH v8 6/6] kernfs: Use RCU to access kernfs_node::name Sebastian Andrzej Siewior
2025-04-07 12:46   ` [PATCH] x86/resctrl: Fix rdtgroup_mkdir()'s unlocked use of kernfs_node::name James Morse
2025-04-07 18:08     ` Reinette Chatre
2025-04-07 18:26     ` Ingo Molnar [this message]
2025-04-09 10:11     ` [tip: x86/urgent] " tip-bot2 for James Morse
2025-02-13 16:33 ` [PATCH v8 0/6] kernfs: Use RCU to access kernfs_node::{parent|name} Tejun Heo
2025-02-13 18:13   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z_QYwMn5dAcTOglC@gmail.com \
    --to=mingo@kernel.org \
    --cc=babu.moger@amd.com \
    --cc=bigeasy@linutronix.de \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=james.morse@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=reinette.chatre@intel.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox