From: Raag Jadav <raag.jadav@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: gregkh@linuxfoundation.org, david.m.ertman@intel.com,
ira.weiny@intel.com, lee@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mfd: core: Support auxiliary device
Date: Tue, 8 Apr 2025 11:04:59 +0300 [thread overview]
Message-ID: <Z_TYq5J0CPFvdm7e@black.fi.intel.com> (raw)
In-Reply-To: <Z_OQqgSjHxq6kwDp@smile.fi.intel.com>
On Mon, Apr 07, 2025 at 11:45:30AM +0300, Andy Shevchenko wrote:
> On Mon, Apr 07, 2025 at 11:44:50AM +0300, Andy Shevchenko wrote:
> > On Mon, Apr 07, 2025 at 01:16:14PM +0530, Raag Jadav wrote:
> > > Extend MFD subsystem to support auxiliary child device. This is useful
> > > for MFD usecases where parent device is on a discoverable bus and doesn't
> > > fit into the platform device criteria. Purpose of this implementation is
> > > to provide discoverable MFDs just enough infrastructure to register
> > > independent child devices with their own memory and interrupt resources
> > > without abusing the platform device.
> > >
> > > Current support is limited to just PCI type MFDs, but this can be further
> > > extended to support other types like USB in the future.
> >
> > > PS: I'm leaning towards not doing any of the ioremap or regmap on MFD
> > > side and think that we should enforce child devices to not overlap.
> >
> > Yes, but we will have the cases in the future, whatever,
> > for the first step it's okay.
> >
> > > If there's a need to handle common register access by parent device,
> > > then I think it warrants its own driver which adds auxiliary devices
> > > along with a custom interface to communicate with them, and MFD on
> > > AUX is not the right solution for it.
>
> And yes, I still consider enforcing regmap is the right step to go.
Unless there's an explicit need for it, I think we should leave that
choice to the individial drivers instead of forcing them to revamp.
But let's see what Lee and Greg have to say about this.
Raag
next prev parent reply other threads:[~2025-04-08 8:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 7:46 [PATCH v2] mfd: core: Support auxiliary device Raag Jadav
2025-04-07 8:44 ` Andy Shevchenko
2025-04-07 8:45 ` Andy Shevchenko
2025-04-08 8:04 ` Raag Jadav [this message]
2025-04-08 8:48 ` Andy Shevchenko
2025-04-08 7:58 ` Raag Jadav
2025-04-08 8:46 ` Andy Shevchenko
2025-04-08 13:54 ` Raag Jadav
2025-04-07 11:32 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_TYq5J0CPFvdm7e@black.fi.intel.com \
--to=raag.jadav@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=david.m.ertman@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=ira.weiny@intel.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox