[PATCH v2] selftests/x86/lam: fix resource leak in do_uring() and allocate_dsa_pasid()

Malaya Kumar Rout
2025-04-07T10:45:10Z

Exception branch returns without closing
the file descriptors 'file_fd' and 'fd'

Signed-off-by: Malaya Kumar Rout <malayarout91@gmail.com>
:wq
---
tools/testing/selftests/x86/lam.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/tools/testing/selftests/x86/lam.c b/tools/testing/selftests/x86/lam.c
index 18d736640ece..1d3631ce4b69 100644
--- a/tools/testing/selftests/x86/lam.c
+++ b/tools/testing/selftests/x86/lam.c
@@ -682,7 +682,7 @@ int do_uring(unsigned long lam)
return 1;

if (fstat(file_fd, &st) < 0)
- return 1;
+ goto cleanup;

off_t file_sz = st.st_size;

@@ -690,7 +690,7 @@ int do_uring(unsigned long lam)

fi = malloc(sizeof(*fi) + sizeof(struct iovec) * blocks);
if (!fi)
- return 1;
+ goto cleanup;

fi->file_sz = file_sz;
fi->file_fd = file_fd;
@@ -698,7 +698,7 @@ int do_uring(unsigned long lam)
ring = malloc(sizeof(*ring));
if (!ring) {
free(fi);
- return 1;
+ goto cleanup;
}

memset(ring, 0, sizeof(struct io_ring));
@@ -729,6 +729,8 @@ int do_uring(unsigned long lam)
}

free(fi);
+cleanup:
+ close(file_fd);

return ret;
}
@@ -1189,9 +1191,10 @@ void *allocate_dsa_pasid(void)

wq = mmap(NULL, 0x1000, PROT_WRITE,
MAP_SHARED | MAP_POPULATE, fd, 0);
- if (wq == MAP_FAILED)
+ if (wq == MAP_FAILED){
+ close(fd);
perror("mmap");
-
+ }
return wq;
}

--
2.43.0