From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F9D2202C42 for ; Wed, 16 Apr 2025 17:41:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744825315; cv=none; b=aJhJriwShfKh4dRWL/4Q2XUeRaJK2F+hSN9FMgcH4xeRnFXesyn97ds8wAcefpVGMCag7OMkNbpxj5kapRJd6saaVC7ofMFj4bxQe0N6vrGl7S9aRye26pLluC0FlatW9X6EpBQDQOY9UY24b2lpu/h8e7rYjSoecHflFk/svQM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744825315; c=relaxed/simple; bh=W7bBtLlluteHP/1dAH+Ya9l7v9aR1LVZvIfTf+Z30DM=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BTLU8d9vHISCo5+zf8misyDiynS6HBmjcG026TBwJVOvdIa9McwlDIwHkpSvGpdOeWNinq/MVL3hz/K+tFfI1qhYWR0+eZhgbcVh23vT8pSHnCYhCOwjDkBxWtaVUUvriq6RP1AL4/v51Lr1Hr5PY7RnN8Tj6TQDQOWLHjEJaWM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=INIiMUlm; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="INIiMUlm" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5e5deb6482cso1979159a12.1 for ; Wed, 16 Apr 2025 10:41:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1744825312; x=1745430112; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=F/+k1VaPPfC6JjSP1qAD5erxrr3Ql1dchYoION8KrN4=; b=INIiMUlmJ16tGuQVFvdcInPU6DmNXr6/gZ3TDNQYNZyfPLyYsAZ6uurwWn+a/23ZF+ mSctnYE022rQOVZmUfG09MDSJvraPebPxuar3yb72otY6H1gBxmogVJ1W/zwiKQo+j5+ m4v8CyDvTfY+oSmHpSb9CfoBrH629D6U/27hrPrtGWoyta9raQXVbEBIdVAiOABvdm87 0zTU0hpSm/CoCDis6b9J3OoDmj0BY7EsrYFwDREd/1oBT/dq7gZ+ZbX+BkPXezPR9PTa igWPjF/Ky1UmyVu1wPICDR+6cxvPjLMmnQbQRU3cq5Cp/aYWcJezuVFZtwv1VlwQfVkm CBVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744825312; x=1745430112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=F/+k1VaPPfC6JjSP1qAD5erxrr3Ql1dchYoION8KrN4=; b=d6iNXvXuaUb00S7mwilt3wBMn7aVVsoT2qPmEKD4Fu0w9FxmfgervMAfYJk+xQY8j+ 4eK7EDaODBSRz7kM9kzPP2ByrruadROtNgMAkKjJPMqHU2tJZlAyq4MBWgwMZ11x1ic/ C7NGCpD2+Go8qCWop0c7OpGk+fGaXkXqBgK0VcE38kswVvN77IGAM5lHdjBwjsN4B4uJ D/IC/xeM6MKElEgJG1nBOv0px8IQYxaClpNHDkxLrYaVNSW2FyrzZ5K1EY5PHQmrSofa bIt+pmoi5gIKfW/vl41+ofD19KILYa2SWmR+Ub6ptOPDrNJpH80p9Ph+uE0/vMAA9TjQ tSyA== X-Forwarded-Encrypted: i=1; AJvYcCWxb29YiZoi8JDohKFlO7cAfu77dli/RQjhdvuadixRUcFwUzrPHrV12+kQr7NX509NZGBwhsnVeslaWGU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2F7b7g6vidfvV8fudEWKwHfkGJxWdWMGbXDvGtaOVUjlnNtCp OUaH78jDdPtBEkfRkda/O81ZIckJRi3dTibkRQLe7+ivF/EX/ztTem3xfaLNTxs= X-Gm-Gg: ASbGncul9ZRVW8/VtjHli8mhUKkqFTeVd3a/ifYu0QQgafi1kpX03PWGQ2+vaxZ85DZ 2NlEaI7MLljtRdZYsjdbz74aXH4Rz9J0EVgi6Cvcb1KBUEmoyzlXRDIJ1KGO+F339EFqYlXpOZi qFucOdDOMMyfXD/y2B9ARMfhl6FJKcgthUmYPb1hR2/hTGBARPMDHQZdp5oW0ZKQMmMY2lb9RXM 9y+/DG5YXQSBeMtRhiLmZfj8D6itainhxM+bIE2nIErw6cX7EoavCK1la1mUzV5yUIOc6uGvP+K e8IlLHZHkn7uwANg0X/9GcbupkccYl0X0D9f4PqCrNrtboO4q1LVT/m3OECN+Om8irXuTNU= X-Google-Smtp-Source: AGHT+IG7VChiUUBXbPZt2UsOsnvfmMZv1kTPdmKDqxu0K/iyE0OKTXPbM6G10YQaE7vDg/k0DkFp+g== X-Received: by 2002:a17:907:1b2a:b0:ac7:b1eb:8283 with SMTP id a640c23a62f3a-acb5220ab4dmr51498666b.17.1744825311718; Wed, 16 Apr 2025 10:41:51 -0700 (PDT) Received: from localhost (93-44-188-26.ip98.fastwebnet.it. [93.44.188.26]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acb3d1ce081sm159581866b.154.2025.04.16.10.41.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 10:41:51 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Wed, 16 Apr 2025 19:43:14 +0200 To: Stefan Wahren Cc: Andrea della Porta , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Lorenzo Pieralisi , Krzysztof Wilczynski , Manivannan Sadhasivam , Bjorn Helgaas , Linus Walleij , Catalin Marinas , Will Deacon , Bartosz Golaszewski , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Saravana Kannan , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, Masahiro Yamada , Herve Codina , Luca Ceresoli , Thomas Petazzoni , Andrew Lunn , Phil Elwell , Dave Stevenson , kernel-list@raspberrypi.com Subject: Re: [PATCH v8 09/13] arm64: dts: Add board DTS for Rpi5 which includes RP1 node Message-ID: References: <526751d2-c7e8-4097-9454-c9049b880225@gmx.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <526751d2-c7e8-4097-9454-c9049b880225@gmx.net> Hi Stefan, On 13:48 Mon 14 Apr , Stefan Wahren wrote: > Hi Andrea, > > Am 19.03.25 um 22:52 schrieb Andrea della Porta: > > Add the board 'monolithic' DTS for RaspberryPi 5 which includes > > the RP1 node definition. The inclusion treeis as follow (the > > arrow points to the includer): > > > > rp1-common.dtsi ----> rp1-nexus.dtsi ----> bcm2712-rpi-5-b-monolithic.dts > > ^ > > | > > bcm2712-rpi-5-b.dts > sorry for the delay. I'm not happy with the monolithic appendix. > > How about bcm2712-rpi-5-b-rp1.dts or something more self-explaining?Regards Sure, good catch. I'd go even further saying that we can rename (or merge if the destination file already exists) as: bcm2712-rpi-5-b.dts -> bcm2712-rpi-5-b-norp1.dts (or some better suffix other than -norp1) bcm2712-rpi-5-b-monolithic.dts -> bcm2712-rpi-5-b.dts so the monolithic one, which seems to be the 'safest' option as of now, would be the default dtb. Do you think it could be ok? > > This is designed to maximize the compatibility with downstream DT > > while ensuring that a fully defined DT (one which includes the RP1 > > node as opposed to load it from overlay at runtime) is present > > since early boot stage. > > > > Signed-off-by: Andrea della Porta > > --- > > Right now bcm2712-rpi-5-b.dts is the overlay-ready DT which will make > > the RP1 driver to load the RP1 dtb overlay at runtime, while > > bcm2712-rpi-5-b-monolithic.dts is the fully defined one (i.e. it > > already contains RP1 node, so no overlay is loaded nor needed). > > Depending on which one we want to be considered the default, we can > > swap the file names to align with downstream naming convention that > > has only the fully defined DT called bcm2712-rpi-5-b.dts. > Could you please move some of this good explanation into this dts file as > comment? Sure. Thanks, Andrea > > --- > > arch/arm64/boot/dts/broadcom/Makefile | 1 + > > .../boot/dts/broadcom/bcm2712-rpi-5-b-monolithic.dts | 8 ++++++++ > > 2 files changed, 9 insertions(+) > > create mode 100644 arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-monolithic.dts > > > > diff --git a/arch/arm64/boot/dts/broadcom/Makefile b/arch/arm64/boot/dts/broadcom/Makefile > > index 3d0efb93b06d..4836c6da5bee 100644 > > --- a/arch/arm64/boot/dts/broadcom/Makefile > > +++ b/arch/arm64/boot/dts/broadcom/Makefile > > @@ -7,6 +7,7 @@ dtb-$(CONFIG_ARCH_BCM2835) += bcm2711-rpi-400.dtb \ > > bcm2711-rpi-4-b.dtb \ > > bcm2711-rpi-cm4-io.dtb \ > > bcm2712-rpi-5-b.dtb \ > > + bcm2712-rpi-5-b-monolithic.dtb \ > > bcm2712-d-rpi-5-b.dtb \ > > bcm2837-rpi-3-a-plus.dtb \ > > bcm2837-rpi-3-b.dtb \ > > diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-monolithic.dts b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-monolithic.dts > > new file mode 100644 > > index 000000000000..3aeee678b0bc > > --- /dev/null > > +++ b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-monolithic.dts > > @@ -0,0 +1,8 @@ > > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > > +/dts-v1/; > > + > > +#include "bcm2712-rpi-5-b.dts" > > + > > +&pcie2 { > > + #include "rp1-nexus.dtsi" > > +}; >