Re: [PATCH] ipmi:si: Move SI type information into an info structure

Andy Shevchenko
2025-04-17T15:34:11Z

On Wed, Apr 16, 2025 at 08:45:51PM +0300, Andy Shevchenko wrote:
> On Wed, Apr 16, 2025 at 07:09:12AM -0500, Corey Minyard wrote:
> > Andy reported:
> >
> > Debian clang version 19.1.7 is not happy when compiled with
> > `make W=1` (note, CONFIG_WERROR=y is the default):
> >
> > ipmi_si_platform.c:268:15: error: cast to smaller integer type 'enum si_type'
> > +from 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast]
> > 268 | io.si_type = (enum
> > +si_type)device_get_match_data(&pdev->dev);
> >
> > The IPMI SI type is an enum that was cast into a pointer that was
> > then cast into an enum again. That's not the greatest style, so
> > instead create an info structure to hold the data and use that.
>
> I'm going to test this today or latest tomorrow, below some comments.

I have noticed the commit 37631eee2063 ("ipmi:si: Move SI type information into
an info structure") which is in Linux Next and it compiles for me as expected,
thank you for the prompt fix!

--
With Best Regards,
Andy Shevchenko