From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE94E1AF0AF; Wed, 9 Apr 2025 16:00:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744214435; cv=none; b=t3XvN61gNdhPCXzuQQMMMa+43vspzKdf9bqtxK7QQqBD2XjC739D7k/sbMPCuUiH9cna+z82c0ZokxZ155k2Hjp/WHeTfIa+gwq3pt8TFfK5qoZS5iqMD3fo1A/FCfB3QISNKpL9YoShlZnhiaZsxEZLY5QQFfp6m4bYhlvt7oo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744214435; c=relaxed/simple; bh=uMKu+jFYPg96rqO8KN7gZyvKhno3jI10KclYtsC1aKQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OAy9G6fzq6Eljxhurc9bHWSetH1skvy2Pt4W26577Ge5vgkI1gebPKiPHZTfqth66ItoGezVxfgr4oj147s4q4DKLfMuvHTivL2LS4pXLMBtpRsb7rBIL3qLcmHKMlu6YdD6HLTAhkrKoAPdTDmRei90B1SMmO2B8bfjfiuNXNY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=bUU/TICQ; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="bUU/TICQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1744214433; x=1775750433; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=uMKu+jFYPg96rqO8KN7gZyvKhno3jI10KclYtsC1aKQ=; b=bUU/TICQJOcEGKRV/B0u2vAEJn45Wl7Ii03Woj7Era/9dUHAj80QTG/6 vAKO6mrL/0+mnSk+MX+tbqXBoMn3G+IVWIEh7jeAvlss8rDZ3fu2yrjbY Ge7Wh/yyEDFzobFzNwbXGf1LPK1frEE61bJjG4HprKbrtymgDA5IEKJ3Q Y0LS53wceGGkP7yXfG0BR1YpQJol9wVoJm4wCe+xPrANw9Bf80f1tcI07 9DiEQbyaQZvcbPl1e22h2byvILVFZXlGcjUQ0ef1oFexY0jP617FIk5Or LhbSSlMqhguoEB0WqMUB4uAFNntqAkMnakH9rUvYNxYdN9v4kvHAxQeqv Q==; X-CSE-ConnectionGUID: d4g4DevrTi6nITvsL5mFEA== X-CSE-MsgGUID: KMdxu9A4SyKSiWkQq126xQ== X-IronPort-AV: E=McAfee;i="6700,10204,11399"; a="57069910" X-IronPort-AV: E=Sophos;i="6.15,200,1739865600"; d="scan'208";a="57069910" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2025 09:00:32 -0700 X-CSE-ConnectionGUID: M6haKlFeT6mLpHo/o0g4oQ== X-CSE-MsgGUID: YEcl2JY6RJ+PfT5TKRRWKg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,200,1739865600"; d="scan'208";a="159614553" Received: from smile.fi.intel.com ([10.237.72.58]) by orviesa002.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2025 09:00:28 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98.2) (envelope-from ) id 1u2Xqi-0000000Amra-49ph; Wed, 09 Apr 2025 19:00:24 +0300 Date: Wed, 9 Apr 2025 19:00:24 +0300 From: Andy Shevchenko To: Mark Brown Cc: Mathieu Dubois-Briand , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kamel Bouhara , Linus Walleij , Bartosz Golaszewski , Dmitry Torokhov , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Michael Walle , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-input@vger.kernel.org, linux-pwm@vger.kernel.org, =?iso-8859-1?Q?Gr=E9gory?= Clement , Thomas Petazzoni Subject: Re: [PATCH v6 05/12] regmap: irq: Remove unreachable goto Message-ID: References: <20250409-mdb-max7360-support-v6-0-7a2535876e39@bootlin.com> <20250409-mdb-max7360-support-v6-5-7a2535876e39@bootlin.com> <1b280408-888e-48e1-8e6b-de4e7a913e74@sirena.org.uk> <7126e672-a829-489e-a0c0-8d6d64a8b2f4@sirena.org.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7126e672-a829-489e-a0c0-8d6d64a8b2f4@sirena.org.uk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Wed, Apr 09, 2025 at 04:46:04PM +0100, Mark Brown wrote: > On Wed, Apr 09, 2025 at 06:38:32PM +0300, Andy Shevchenko wrote: > > On Wed, Apr 09, 2025 at 04:19:27PM +0100, Mark Brown wrote: > > > > BUG() can be compiled out, CONFIG_BUG. > > > Yes, and it's still has unreachable() there. So, this change is correct. > > See include/asm-generic/bug.h for the details of the implementation. > > And yes, if we have an architecture that does not do this way, it has to > > be fixed. > > unreachable() just annotates things, AFAICT it doesn't actually > guarantee to do anything in particular if the annotation turns out to be > incorrect. I;m not sure I follow. unreachable is a wrapper on top of __builtin_unreachable() which is intrinsic of the compiler. https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html#index-_005f_005fbuiltin_005funreachable -- With Best Regards, Andy Shevchenko