From: Danilo Krummrich <dakr@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
FUJITA Tomonori <fujita.tomonori@gmail.com>,
richard@nod.at, anton.ivanov@cambridgegreys.com,
johannes@sipsolutions.net, linux-um@lists.infradead.org,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
Logan Gunthorpe <logang@deltatee.com>,
Stephen Bates <sbates@raithlin.com>,
Dinh Nguyen <dinguyen@kernel.org>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v1] um: fix incompatible argument type in iounmap()
Date: Wed, 9 Apr 2025 19:30:19 +0200 [thread overview]
Message-ID: <Z_auq9XEUxMwKVoN@cassiopeiae> (raw)
In-Reply-To: <CAMuHMdWtgSjxeGYJVNzeWPOCd9nUWeKQnCtFQaROQ1o=r_-QwQ@mail.gmail.com>
On Wed, Apr 09, 2025 at 07:07:56PM +0200, Geert Uytterhoeven wrote:
> Hi Miguel,
>
> CC arnd
>
> On Wed, 9 Apr 2025 at 16:48, Miguel Ojeda
> <miguel.ojeda.sandonis@gmail.com> wrote:
> > On Wed, Apr 9, 2025 at 8:16 AM FUJITA Tomonori
> > <fujita.tomonori@gmail.com> wrote:
> > >
> > > Align iounmap() signature with other architectures.
> >
> > Most indeed have `volatile`, but nios2 and m68k don't -- Cc'ing them
> > just in case.
>
> Indeed. Apparently the volatile keyword has not always been there...
> Why does iounmap() need the volatile keyword?
> Why does pci_iounmap() not have the volatile keyword?
I think none of the functions within rust/helpers/io.c need volatile, since they
just defer to the corresponding C function / macro.
This probably has been a copy/paste mistake of the function signatures and
should be removed instead.
- Danilo
next prev parent reply other threads:[~2025-04-09 17:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 6:11 [PATCH v1] um: fix incompatible argument type in iounmap() FUJITA Tomonori
2025-04-09 14:47 ` Miguel Ojeda
2025-04-09 17:07 ` Geert Uytterhoeven
2025-04-09 17:30 ` Danilo Krummrich [this message]
2025-04-10 12:56 ` FUJITA Tomonori
2025-04-09 19:07 ` Arnd Bergmann
2025-04-10 7:30 ` Geert Uytterhoeven
2025-04-10 13:05 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_auq9XEUxMwKVoN@cassiopeiae \
--to=dakr@kernel.org \
--cc=anton.ivanov@cambridgegreys.com \
--cc=arnd@arndb.de \
--cc=dinguyen@kernel.org \
--cc=fujita.tomonori@gmail.com \
--cc=geert@linux-m68k.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=logang@deltatee.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=richard@nod.at \
--cc=rust-for-linux@vger.kernel.org \
--cc=sbates@raithlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox