From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 492AF26A1C3 for ; Thu, 10 Apr 2025 12:14:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744287257; cv=none; b=f5TtWcbD6VOFdCIdcZrLVHlSjoFtubPu1X03D8ijAkDbUyt08YdMMt0PoNL6k3yxjFhVOSILJ19ms2SPnSMl2YGthkKZ0XGq3dGM+mNGbDCnjlBsz4IswYC9fUVXsbsSFYEzTRjeKj9LAVPStVIkZ586KqE3FQGyan5CKwh3Vpw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744287257; c=relaxed/simple; bh=yBgj6TSX3ktKPTDwDouO0Xsf2K/CIJ5+N+hcweBHMEM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IZvx7sYnLXnAPMlYjd4t2XKsJbPHpeOqRhDgXUdfydW57HOCPDErXBbMNDIUFmrsYB+ywSNlHjOK1CE1r0JsbfsjOlNsE6k4oR/s2ojvuH1fUHoqJmDt9jt3LBZIkYdnUqhyotAVd3oSSNyqC+2PGjBKBguEgWPLPqcHtKdBp6A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1u2qnI-0000d6-8K; Thu, 10 Apr 2025 14:14:08 +0200 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u2qnG-004Gek-2j; Thu, 10 Apr 2025 14:14:06 +0200 Received: from ore by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1u2qnG-00AN5k-22; Thu, 10 Apr 2025 14:14:06 +0200 Date: Thu, 10 Apr 2025 14:14:06 +0200 From: Oleksij Rempel To: Krzysztof =?utf-8?Q?Ha=C5=82asa?= Cc: netdev , Oliver Neukum , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Jose Ignacio Tornos Martinez , Ming Lei Subject: Re: [PATCH v2] usbnet: asix AX88772: leave the carrier control to phylink Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On Tue, Apr 08, 2025 at 01:59:41PM +0200, Krzysztof Hałasa wrote: > ASIX AX88772B based USB 10/100 Ethernet adapter doesn't come > up ("carrier off"), despite the built-in 100BASE-FX PHY positive link > indication. The internal PHY is configured (using EEPROM) in fixed > 100 Mbps full duplex mode. > > The primary problem appears to be using carrier_netif_{on,off}() while, > at the same time, delegating carrier management to phylink. Use only the > latter and remove "manual control" in the asix driver. > > I don't have any other AX88772 board here, but the problem doesn't seem > specific to a particular board or settings - it's probably > timing-dependent. > > Remove unused asix_adjust_link() as well. > > Signed-off-by: Krzysztof Hałasa Tested-by: Oleksij Rempel Link detection is still working on variants with copper interface. Thank you! Best Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |