From: Frederic Weisbecker <frederic@kernel.org>
To: Gabriele Monaco <gmonaco@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, Waiman Long <longman@redhat.com>
Subject: Re: [PATCH] timers: Exclude isolated cpus from timer migation
Date: Thu, 10 Apr 2025 17:32:16 +0200 [thread overview]
Message-ID: <Z_fkgN1ro9AeM1QY@localhost.localdomain> (raw)
In-Reply-To: <1c60e19d1cebc09a8fd89f073c3dbec80c8ddbf1.camel@redhat.com>
Le Thu, Apr 10, 2025 at 05:05:52PM +0200, Gabriele Monaco a écrit :
> I'm not understanding what is going to be invasive in this case.
> Aren't we just talking about not allowing isolcpus to pull timers from
> other cpus?
Right, but in order to do that you need to avoid remotely executing
timers. And for that we need your initial patch (after reviews have
been addressed). Right?
> Let's ignore for now the global timers started on those CPUs, I'm not
> aware of complaints regarding that.
>
> As far as I understand, the change would allow timer migration to work
> normally out of isolcpus and among housekeeping ones, we are not
> forcing any migration that would potentially introduce overhead or
> missed timers.
> Or am I oversimplifying it?
Global timers only migrate:
a) When a CPU goes offline (but they should be migrated to
a housekeeping CPU)
b) When a timer executes remotely and re-enqueues itself.
In order to handle b), you must make sure an isolated CPU
can't execute timers remotely. Hence why it must be set
as not available like you did.
Or am I missing something else?
Thanks.
--
Frederic Weisbecker
SUSE Labs
next prev parent reply other threads:[~2025-04-10 15:32 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 6:54 [PATCH] timers: Exclude isolated cpus from timer migation Gabriele Monaco
2025-04-10 8:26 ` Thomas Gleixner
2025-04-10 10:38 ` Gabriele Monaco
2025-04-10 13:03 ` Frederic Weisbecker
2025-04-10 13:15 ` Thomas Gleixner
2025-04-10 13:27 ` Frederic Weisbecker
2025-04-10 13:56 ` Gabriele Monaco
2025-04-10 14:20 ` Frederic Weisbecker
2025-04-10 14:46 ` Thomas Gleixner
2025-04-10 14:54 ` Frederic Weisbecker
2025-04-10 15:06 ` Waiman Long
2025-04-10 14:46 ` Gabriele Monaco
2025-04-10 14:59 ` Frederic Weisbecker
2025-04-10 15:05 ` Gabriele Monaco
2025-04-10 15:32 ` Frederic Weisbecker [this message]
2025-04-11 7:08 ` Gabriele Monaco
2025-04-11 11:31 ` Frederic Weisbecker
2025-04-11 13:02 ` Gabriele Monaco
2025-04-11 22:57 ` Frederic Weisbecker
2025-04-14 8:06 ` Gabriele Monaco
2025-04-10 14:35 ` Waiman Long
2025-04-10 14:43 ` Frederic Weisbecker
2025-04-10 14:49 ` Gabriele Monaco
2025-04-10 14:50 ` Waiman Long
2025-04-10 14:56 ` Frederic Weisbecker
2025-04-10 13:08 ` Thomas Gleixner
2025-04-10 14:21 ` Waiman Long
2025-04-10 14:32 ` Waiman Long
2025-04-11 7:12 ` kernel test robot
2025-04-11 9:27 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_fkgN1ro9AeM1QY@localhost.localdomain \
--to=frederic@kernel.org \
--cc=gmonaco@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox