From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Cc: Tzung-Bi Shih <tzungbi@kernel.org>,
kernel@collabora.com,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Abhijit Gangurde <abhijit.gangurde@amd.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nicolas@fjasle.eu>,
Nipun Gupta <nipun.gupta@amd.com>,
Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com>,
Umang Jain <umang.jain@ideasonboard.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] firmware: coreboot: Generate aliases for coreboot modules
Date: Sun, 21 Jan 2024 14:41:29 +0200 [thread overview]
Message-ID: <Za0Q-em5R2_9cX7q@smile.fi.intel.com> (raw)
In-Reply-To: <49b42da1-a74b-433c-b018-0742f850f680@notapiano>
On Wed, Jan 17, 2024 at 09:53:23AM -0300, Nícolas F. R. A. Prado wrote:
> On Sun, Jan 14, 2024 at 07:08:13PM +0200, Andy Shevchenko wrote:
> > On Thu, Jan 11, 2024 at 12:11:47PM -0300, Nícolas F. R. A. Prado wrote:
> > > Generate aliases for coreboot modules to allow automatic module probing.
...
> > > +/**
> > > + * struct coreboot_device_id - Identifies a coreboot table entry
> > > + * @tag: tag ID
> > > + */
> > > +struct coreboot_device_id {
> > > + __u32 tag;
> > > +};
> >
> > Don't you want to have a driver data or so associated with this?
>
> There's no need for it currently in any driver. This struct is being created
> simply to allow auto modprobe. So it seems reasonable to leave it out and add it
> later when/if needed.
The problem is that you introduce a kinda ABI here, how do you handle this later?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-01-21 12:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 15:11 [PATCH 0/4] Allow coreboot modules to autoload and enable cbmem in the arm64 defconfig Nícolas F. R. A. Prado
2024-01-11 15:11 ` [PATCH 1/4] firmware: coreboot: Generate modalias uevent for devices Nícolas F. R. A. Prado
2024-01-12 0:37 ` Brian Norris
2024-01-12 12:24 ` Nícolas F. R. A. Prado
2024-01-11 15:11 ` [PATCH 2/4] firmware: coreboot: Generate aliases for coreboot modules Nícolas F. R. A. Prado
2024-01-14 17:08 ` Andy Shevchenko
2024-01-17 12:53 ` Nícolas F. R. A. Prado
2024-01-21 12:41 ` Andy Shevchenko [this message]
2024-01-22 18:24 ` Nícolas F. R. A. Prado
2024-01-11 15:11 ` [PATCH 3/4] firmware: google: cbmem: Add to module device table Nícolas F. R. A. Prado
2024-01-12 0:38 ` Brian Norris
2024-01-12 12:26 ` Nícolas F. R. A. Prado
2024-01-15 2:53 ` kernel test robot
2024-01-16 17:40 ` Brian Norris
2024-01-11 15:11 ` [PATCH 4/4] arm64: defconfig: Enable support for cbmem entries in the coreboot table Nícolas F. R. A. Prado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Za0Q-em5R2_9cX7q@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=abhijit.gangurde@amd.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@collabora.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=nfraprado@collabora.com \
--cc=nicolas@fjasle.eu \
--cc=nipun.gupta@amd.com \
--cc=pieter.jansen-van-vuuren@amd.com \
--cc=tzungbi@kernel.org \
--cc=umang.jain@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox