[PATCH] kbuild: fix W= flags in the help message

[PATCH] kbuild: fix W= flags in the help message

[Masahiro Yamada]

W=c and W=e are supported.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index f288eb2dc8fd..8c6a935c62e6 100644
--- a/Makefile
+++ b/Makefile
@@ -1653,7 +1653,7 @@ help:
 	@echo  '                       (sparse by default)'
 	@echo  '  make C=2   [targets] Force check of all c source with $$CHECK'
 	@echo  '  make RECORDMCOUNT_WARN=1 [targets] Warn about ignored mcount sections'
-	@echo  '  make W=n   [targets] Enable extra build checks, n=1,2,3 where'
+	@echo  '  make W=n   [targets] Enable extra build checks, n=1,2,3,c,e where'
 	@echo  '		1: warnings which may be relevant and do not occur too often'
 	@echo  '		2: warnings which occur quite often but may still be relevant'
 	@echo  '		3: more obscure warnings, can most likely be ignored'
-- 
2.40.1

Re: [PATCH] kbuild: fix W= flags in the help message

[Nicolas Schier]

On Sat, Jan 20, 2024 at 05:32:55PM +0900, Masahiro Yamada wrote:
> W=c and W=e are supported.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
> 
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index f288eb2dc8fd..8c6a935c62e6 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1653,7 +1653,7 @@ help:
>  	@echo  '                       (sparse by default)'
>  	@echo  '  make C=2   [targets] Force check of all c source with $$CHECK'
>  	@echo  '  make RECORDMCOUNT_WARN=1 [targets] Warn about ignored mcount sections'
> -	@echo  '  make W=n   [targets] Enable extra build checks, n=1,2,3 where'
> +	@echo  '  make W=n   [targets] Enable extra build checks, n=1,2,3,c,e where'

In the top of scripts/Makefile.extrawarn we have kind of a duplication
of this description.  Might you want to update that too?

Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>

Re: [PATCH] kbuild: fix W= flags in the help message

[Masahiro Yamada]

On Tue, Jan 23, 2024 at 12:21 AM Nicolas Schier <n.schier@avm.de> wrote:
>
> On Sat, Jan 20, 2024 at 05:32:55PM +0900, Masahiro Yamada wrote:
> > W=c and W=e are supported.
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> > ---
> >
> >  Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Makefile b/Makefile
> > index f288eb2dc8fd..8c6a935c62e6 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -1653,7 +1653,7 @@ help:
> >       @echo  '                       (sparse by default)'
> >       @echo  '  make C=2   [targets] Force check of all c source with $$CHECK'
> >       @echo  '  make RECORDMCOUNT_WARN=1 [targets] Warn about ignored mcount sections'
> > -     @echo  '  make W=n   [targets] Enable extra build checks, n=1,2,3 where'
> > +     @echo  '  make W=n   [targets] Enable extra build checks, n=1,2,3,c,e where'
>
> In the top of scripts/Makefile.extrawarn we have kind of a duplication
> of this description.  Might you want to update that too?

W=e is already mentioned in scripts/Makefile.extrawarn.
W=c is handled in scripts/kconfig/Makefile.

So, I believe it is OK as-is.





> Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>



-- 
Best Regards
Masahiro Yamada