From: "Christian A. Ehrhardt" <lk@c--e.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
linux-usb@vger.kernel.org, Dell.Client.Kernel@dell.com,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Jack Pham" <quic_jackp@quicinc.com>,
"Fabrice Gasnier" <fabrice.gasnier@foss.st.com>,
"Samuel Čavoj" <samuel@cavoj.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] usb: ucsi: Add missing ppm_lock
Date: Wed, 17 Jan 2024 08:45:32 +0100 [thread overview]
Message-ID: <ZaeFnId6Ln3VUE5n@cae.in-ulm.de> (raw)
In-Reply-To: <2024011726-exhaust-writing-29d4@gregkh>
On Wed, Jan 17, 2024 at 06:44:40AM +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 16, 2024 at 11:40:39PM +0100, Christian A. Ehrhardt wrote:
> > Calling ->sync_write must be done while holding the PPM lock as the
> > mailbox logic does not support concurrent commands.
> >
> > Thus protect the only call to ucsi_acknowledge_connector_change
> > with the PPM lock as it calls ->sync_write. All other calls to
> > ->sync_write already happen under the PPM lock.
> >
> > Signed-off-by: Christian A. Ehrhardt <lk@c--e.de>
> > ---
> > NOTE: This is not a theoretical issue. I've seen problems resulting
> > from the missing lock on real hardware.
>
> What commit id does this fix?
It's hard to tell (due to rewrites, logic and API changes). After
digging a bit more I think it is at least a theoretical issues since
the introduction of partner tasks.
I'll wait a bit for additional feedback and fix this and other issues
noticed by your patch bot (sorry for those) in the next iteration.
> Should it be cc: stable?
Not sure. The race is triggered much more ofter after the quirk added
in patch 3/3, so this may not be a practical issue before that.
I'll add the tag in the next iteration, though.
thanks Christian
next prev parent reply other threads:[~2024-01-17 7:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 22:40 [PATCH 0/3] UCSI fixes Christian A. Ehrhardt
2024-01-16 22:40 ` [PATCH 1/3] usb: ucsi: Add missing ppm_lock Christian A. Ehrhardt
2024-01-17 5:44 ` Greg Kroah-Hartman
2024-01-17 7:45 ` Christian A. Ehrhardt [this message]
2024-01-16 22:40 ` [PATCH 2/3] usb: ucsi_acpi: Fix command completion handling Christian A. Ehrhardt
2024-01-17 5:44 ` Greg Kroah-Hartman
2024-01-16 22:40 ` [PATCH 3/3] usb: ucsi_acpi: Quirk to ack a connector change ack cmd Christian A. Ehrhardt
2024-01-17 23:38 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZaeFnId6Ln3VUE5n@cae.in-ulm.de \
--to=lk@c--e.de \
--cc=Dell.Client.Kernel@dell.com \
--cc=fabrice.gasnier@foss.st.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_jackp@quicinc.com \
--cc=samuel@cavoj.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox