From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Elliot Ayrey <elliot.ayrey@alliedtelesis.co.nz>
Cc: Marcin Wojtas <marcin.s.wojtas@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH] net: mvpp2: Add EEE get/set to mvpp2 driver
Date: Thu, 18 Jan 2024 08:36:19 +0000 [thread overview]
Message-ID: <ZajjA6Y4UdX5nGNn@shell.armlinux.org.uk> (raw)
In-Reply-To: <20240118015748.3507954-1-elliot.ayrey@alliedtelesis.co.nz>
On Thu, Jan 18, 2024 at 02:57:48PM +1300, Elliot Ayrey wrote:
> Fill in the missing .get_eee and .set_eee functions for the mvpp2
> driver.
This has no benefit without also configuring LPI in the driver.
In any case, you should be calling the phylink functions not the
phylib functions.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2024-01-18 8:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 1:57 [PATCH] net: mvpp2: Add EEE get/set to mvpp2 driver Elliot Ayrey
2024-01-18 8:36 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZajjA6Y4UdX5nGNn@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elliot.ayrey@alliedtelesis.co.nz \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.s.wojtas@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox