public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Kunwu Chan <chentao@kylinos.cn>
Cc: aduggan@synaptics.com, cheiny@synaptics.com,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Input: synaptics-rmi4: Add a null pointer check to the rmi_driver_probe
Date: Thu, 18 Jan 2024 14:32:38 -0800	[thread overview]
Message-ID: <ZamnBjXaKDiqMSTR@google.com> (raw)
In-Reply-To: <20240117073124.143636-1-chentao@kylinos.cn>

Hi Kunwu,

On Wed, Jan 17, 2024 at 03:31:24PM +0800, Kunwu Chan wrote:
> devm_kasprintf() returns a pointer to dynamically allocated memory
> which can be NULL upon failure. Ensure the allocation was successful
> by checking the pointer validity.
> 
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
> Suggested-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

I did not suggest the patch, I merely provided feedback on it, so I
dropped this tag, reworded commit message slightly, and applied.

Thanks.

-- 
Dmitry

      reply	other threads:[~2024-01-18 22:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-17  7:31 [PATCH v2] Input: synaptics-rmi4: Add a null pointer check to the rmi_driver_probe Kunwu Chan
2024-01-18 22:32 ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZamnBjXaKDiqMSTR@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=aduggan@synaptics.com \
    --cc=cheiny@synaptics.com \
    --cc=chentao@kylinos.cn \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox