From: Pavel Machek <pavel@ucw.cz>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: phone-devel@vger.kernel.org,
kernel list <linux-kernel@vger.kernel.org>,
fiona.klute@gmx.de, martijn@brixit.nl, megi@xff.cz,
samuel@sholland.org, heikki.krogerus@linux.intel.com,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: typec: anx7688: Add driver for ANX7688 USB-C HDMI bridge
Date: Fri, 2 Feb 2024 19:09:22 +0100 [thread overview]
Message-ID: <Zb0v0va1A4SvlgCh@mobian> (raw)
In-Reply-To: <2024020126-emote-unsubtly-3394@gregkh>
Hi!
> > --- /dev/null
> > +++ b/drivers/usb/typec/anx7688.c
> > @@ -0,0 +1,1866 @@
> > +/*
> > + * ANX7688 USB-C HDMI bridge/PD driver
> > + *
>
> <snip>
>
> Did this pass checkpatch? I need a spdx line for new files please,
> don't force us to go back and guess in the future, that isn't nice.
Thanks for the review. Fixing checkpatch issues is easy, but it looks
like closer look will be needed at the devicetree probing.
Also, what are the authors preferences about the license? I'd prefer
GPLv2+.
Best regards,
Pavel
next prev parent reply other threads:[~2024-02-02 18:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 10:41 [PATCH] usb: typec: anx7688: Add driver for ANX7688 USB-C HDMI bridge Pavel Machek
2024-02-01 14:59 ` Greg KH
2024-02-02 18:09 ` Pavel Machek [this message]
2024-02-01 15:00 ` Greg KH
2024-02-03 18:18 ` Ondřej Jirman
2024-02-09 19:44 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zb0v0va1A4SvlgCh@mobian \
--to=pavel@ucw.cz \
--cc=fiona.klute@gmx.de \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=martijn@brixit.nl \
--cc=megi@xff.cz \
--cc=phone-devel@vger.kernel.org \
--cc=samuel@sholland.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox