From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BB7F622 for ; Wed, 24 Jan 2024 00:29:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=134.134.136.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706056192; cv=none; b=lGdIHzqf9c5an3/+Pc6eu4XJsYZubdi0BcgQhXZJ33QmmSuUfk36M5JXxPLfQux3K93D/CW42BRyFcl/43tLyPW9L0LbDU+ctANUMZ8+07YFEdHfzYwjObiZL1lVFUaAy7ZzvcBzC1lCfGv1lmzdLD0QjbkeAhHoVZBs4549ihE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706056192; c=relaxed/simple; bh=4o+fyGzGk91J+jkgzxCNpwmSjuJ5oWL5n8Pzy3g80KQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OJjkf8fMfJsmwXlIiF5wFIAJuVTBLx6zSVY4mPBSguW0BtqMx6k2jNDRbmdUes+pLDQ0gb6svNhgXzYtsBKVdVQi51zMSRBBuFMMUfhyp5Dl3pjYTrHacP9QCJDbBP598xfLYSVw17F59uLxEcdWcuXaqy8sSySSo+RvQMYm8BA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Iiy6N1HD; arc=none smtp.client-ip=134.134.136.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Iiy6N1HD" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706056184; x=1737592184; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=4o+fyGzGk91J+jkgzxCNpwmSjuJ5oWL5n8Pzy3g80KQ=; b=Iiy6N1HDX3WiI1Uw3dg8pBmn3PR1nlFin/saRjpjYdiK5vISMg9T4QvO GqGBpX3VXzf1T5Lz7/ZvsBCKbfW4gPMnD1KfjOW4IAmhPBzTi3APKr1cH oGG4Abr39LTVp4Hi7DN94NgL0sKNs1C9XLYsZ0S6FTocVTT/GmZuaZhPO eCGf7EDlmSFbSjqJIScTk6hU3x54R7WRgpOpVb4eU5U9Yoy0HvV28EScg yYZYr1etxq3ZrO1B3geNDv3gvnRsaBc8OtOv2ykQMHsboXrDWqScJoYmh 14Nht5t9eTtYfIJvKRhQxJrSW4jBRiWDikSXoD3J4BdK7MGtZM6YNGg0H g==; X-IronPort-AV: E=McAfee;i="6600,9927,10962"; a="405449805" X-IronPort-AV: E=Sophos;i="6.05,215,1701158400"; d="scan'208";a="405449805" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2024 16:29:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,215,1701158400"; d="scan'208";a="1729124" Received: from agluck-desk3.sc.intel.com (HELO agluck-desk3) ([172.25.222.74]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2024 16:29:43 -0800 Date: Tue, 23 Jan 2024 16:29:42 -0800 From: Tony Luck To: James Morse , Borislav Petkov , "Chatre, Reinette" Cc: "Yu, Fenghua" , Peter Newman , "x86@kernel.org" , Jamie Iles , Babu Moger , "Shen, Xiaochen" , "linux-kernel@vger.kernel.org" , "patches@lists.linux.dev" Subject: Re: [PATCH v2] x86/resctrl: Implement new mba_MBps throttling heuristic Message-ID: References: <20240118214213.59596-1-tony.luck@intel.com> <45d2891e-989a-45c9-a527-8b14ff5f8748@intel.com> <20240122182121.GBZa6yIYPtHQx44EU9@fat_crate.local> <11fc82e0-961f-4c8d-844f-ad4b99067eb3@intel.com> <20240122184755.GCZa64W02KXyeaVXJg@fat_crate.local> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jan 23, 2024 at 05:07:50PM +0000, Luck, Tony wrote: > >> I need to grab an SNC system to re-check that everything still works when re-based. > >> But right now, this looks like adding the SNC series will be easy (famous last words!). > > > > Once you're ready - can you point me at something I can use as a stable branch to rebase onto? > > I'll be running the tests this afternoon. But I'm somewhat confident that they will pass. > > Tree is here: git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux.git branch "hopeful_snc" > > Commits are: > > 793635f10aeb x86/resctrl: Update documentation with Sub-NUMA cluster changes > dca7ba785d6f x86/resctrl: Sub NUMA Cluster detection and enable > e41bd88101c8 x86/resctrl: Introduce snc_nodes_per_l3_cache > ccbab7875197 x86/resctrl: Add node-scope to the options for feature scope > 2f0db8c7072b x86/resctrl: Split the rdt_domain and rdt_hw_domain structures > 22697627cc5f x86/resctrl: Prepare for different scope for control/monitor operations > f3ff831a9042 x86/resctrl: Prepare to split rdt_domain structure > c0679868ee78 x86/resctrl: Prepare for new domain scope > 327b4394f309 x86/resctrl: Implement new mba_MBps throttling heuristic > 5b14817cf87e x86/resctrl: Read supported bandwidth sources using CPUID command > 5699cd082e1f x86/resctrl: Remove hard-coded memory bandwidth limit > 1b908debf53f x86/resctrl: Fix unused variable warning in cache_alloc_hsw_probe() > > Only the last of these (1b908debf53f) had been accepted by Boris into TIP x86/cache > when I cut this tree yesterday. > > Two more applied by Boris today without any changes from what is in my tree, but the > commit IDs in TIP are obviously different from in my tree. > > 54e35eb8611c x86/resctrl: Read supported bandwidth sources from CPUID > 0976783bb123 x86/resctrl: Remove hard-coded memory bandwidth limit > > All the others have the normal risk that Boris will find some way to make them better. All my SNC tests pass. So this tree is as good as I can make it. Boris: After you take/reject "x86/resctrl: Implement new mba_MBps throttling heuristic" in TIP x86/cache I will post v14 of the SNC series rebased to that TIP branch. -Tony