Re: [PATCH net] bnxt_en: Make PTP timestamp HWRM more silent

patchwork-bot+netdevbpf
2024-01-26T22:10:24Z

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 25 Jan 2024 05:41:03 -0800 you wrote:
> commit 056bce63c469 ("bnxt_en: Make PTP TX timestamp HWRM query silent")
> changed a netdev_err() to netdev_WARN_ONCE().
>
> netdev_WARN_ONCE() is it generates a kernel WARNING, which is bad, for
> the following reasons:
>
> * You do not a kernel warning if the firmware queries are late
> * In busy networks, timestamp query failures fairly regularly
> * A WARNING message doesn't bring much value, since the code path
> is clear.
> (This was discussed in-depth in [1])
>
> [...]

Here is the summary with links:
- [net] bnxt_en: Make PTP timestamp HWRM more silent
https://git.kernel.org/netdev/net/c/281cb9d65a95

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.