From: Christoph Hellwig <hch@infradead.org>
To: Samuel Holland <samuel.holland@sifive.com>
Cc: Sami Tolvanen <samitolvanen@google.com>,
Will Deacon <will@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scs: add CONFIG_MMU dependency for vfree_atomic()
Date: Fri, 26 Jan 2024 05:53:46 -0800 [thread overview]
Message-ID: <ZbO5ag2fBt4KIgn9@infradead.org> (raw)
In-Reply-To: <20240122175204.2371009-1-samuel.holland@sifive.com>
On Mon, Jan 22, 2024 at 09:52:01AM -0800, Samuel Holland wrote:
> The shadow call stack implementation fails to build without CONFIG_MMU:
>
> ld.lld: error: undefined symbol: vfree_atomic
> >>> referenced by scs.c
> >>> kernel/scs.o:(scs_free) in archive vmlinux.a
Well, please just provide vfree_atomic for nommu then. vfree maps
to kfree which can be called from atomic context, so vfree_atomic
can do the same.
prev parent reply other threads:[~2024-01-26 13:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 17:52 [PATCH] scs: add CONFIG_MMU dependency for vfree_atomic() Samuel Holland
2024-01-22 19:21 ` Sami Tolvanen
2024-01-26 13:53 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbO5ag2fBt4KIgn9@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samitolvanen@google.com \
--cc=samuel.holland@sifive.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox