From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: James Clark <james.clark@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
linux-perf-users@vger.kernel.org, irogers@google.com,
kan.liang@linux.intel.com, mark.rutland@arm.com,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Changbin Du <changbin.du@huawei.com>,
Yang Jihong <yangjihong1@huawei.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] perf evlist: Fix evlist__new_default() for > 1 core PMU
Date: Fri, 26 Jan 2024 13:25:31 -0300 [thread overview]
Message-ID: <ZbPc-1sqFgb7dJlF@kernel.org> (raw)
In-Reply-To: <ea054381-6ba2-d2f6-8de4-978a78a2ed8b@arm.com>
Em Wed, Jan 24, 2024 at 09:03:57AM +0000, James Clark escreveu:
> On 24/01/2024 00:46, Namhyung Kim wrote:
> > On Tue, Jan 23, 2024 at 2:39 AM James Clark <james.clark@arm.com> wrote:
> >> +++ b/tools/perf/util/evlist.c
> >> @@ -106,6 +106,13 @@ struct evlist *evlist__new_default(void)
> >> evlist = NULL;
> >> }
> >> + if (evlist->core.nr_entries > 1) {
> > I think you need a NULL check for evlist here.
> Oops yes. Or just return on the error above.
Was there a v4? I'm assuming this is for perf-tools, i.e. for v6.8-rc,
right?
- Arnaldo
next prev parent reply other threads:[~2024-01-26 16:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 15:54 [PATCH] perf test: Fix session topology test on heterogeneous systems James Clark
2024-01-22 15:58 ` James Clark
2024-01-22 16:41 ` Liang, Kan
2024-01-22 17:09 ` Ian Rogers
2024-01-23 0:09 ` Ian Rogers
2024-01-23 10:27 ` [PATCH v2] perf evlist: Fix evlist__new_default() for > 1 core PMU James Clark
2024-01-23 10:39 ` [PATCH v3] " James Clark
2024-01-24 0:46 ` Namhyung Kim
2024-01-24 9:03 ` James Clark
2024-01-26 16:25 ` Arnaldo Carvalho de Melo [this message]
2024-01-26 20:49 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbPc-1sqFgb7dJlF@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=changbin.du@huawei.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=yangjihong1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox