* [PATCH bpf-next] bpf: remove unused field "mod" in struct bpf_trampoline
@ 2024-01-28 5:54 Menglong Dong
2024-01-28 9:04 ` Jiri Olsa
2024-01-29 15:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Menglong Dong @ 2024-01-28 5:54 UTC (permalink / raw)
To: andrii
Cc: ast, daniel, john.fastabend, martin.lau, eddyz87, song,
yonghong.song, kpsingh, sdf, haoluo, jolsa, bpf, linux-kernel,
Menglong Dong
It seems that the field "mod" in struct bpf_trampoline is not used
anywhere after the commit 31bf1dbccfb0 ("bpf: Fix attaching
fentry/fexit/fmod_ret/lsm to modules"). So we can just remove it now.
Signed-off-by: Menglong Dong <dongmenglong.8@bytedance.com>
---
include/linux/bpf.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/bpf.h b/include/linux/bpf.h
index b86bd15a051d..1ebbee1d648e 100644
--- a/include/linux/bpf.h
+++ b/include/linux/bpf.h
@@ -1189,7 +1189,6 @@ struct bpf_trampoline {
int progs_cnt[BPF_TRAMP_MAX];
/* Executable image of trampoline */
struct bpf_tramp_image *cur_image;
- struct module *mod;
};
struct bpf_attach_target_info {
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH bpf-next] bpf: remove unused field "mod" in struct bpf_trampoline
2024-01-28 5:54 [PATCH bpf-next] bpf: remove unused field "mod" in struct bpf_trampoline Menglong Dong
@ 2024-01-28 9:04 ` Jiri Olsa
2024-01-29 15:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Olsa @ 2024-01-28 9:04 UTC (permalink / raw)
To: Menglong Dong
Cc: andrii, ast, daniel, john.fastabend, martin.lau, eddyz87, song,
yonghong.song, kpsingh, sdf, haoluo, bpf, linux-kernel
On Sun, Jan 28, 2024 at 01:54:43PM +0800, Menglong Dong wrote:
> It seems that the field "mod" in struct bpf_trampoline is not used
> anywhere after the commit 31bf1dbccfb0 ("bpf: Fix attaching
> fentry/fexit/fmod_ret/lsm to modules"). So we can just remove it now.
>
> Signed-off-by: Menglong Dong <dongmenglong.8@bytedance.com>
Fixes: 31bf1dbccfb0 ("bpf: Fix attaching fentry/fexit/fmod_ret/lsm to modules")
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
> ---
> include/linux/bpf.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/bpf.h b/include/linux/bpf.h
> index b86bd15a051d..1ebbee1d648e 100644
> --- a/include/linux/bpf.h
> +++ b/include/linux/bpf.h
> @@ -1189,7 +1189,6 @@ struct bpf_trampoline {
> int progs_cnt[BPF_TRAMP_MAX];
> /* Executable image of trampoline */
> struct bpf_tramp_image *cur_image;
> - struct module *mod;
> };
>
> struct bpf_attach_target_info {
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH bpf-next] bpf: remove unused field "mod" in struct bpf_trampoline
2024-01-28 5:54 [PATCH bpf-next] bpf: remove unused field "mod" in struct bpf_trampoline Menglong Dong
2024-01-28 9:04 ` Jiri Olsa
@ 2024-01-29 15:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-01-29 15:50 UTC (permalink / raw)
To: Menglong Dong
Cc: andrii, ast, daniel, john.fastabend, martin.lau, eddyz87, song,
yonghong.song, kpsingh, sdf, haoluo, jolsa, bpf, linux-kernel
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:
On Sun, 28 Jan 2024 13:54:43 +0800 you wrote:
> It seems that the field "mod" in struct bpf_trampoline is not used
> anywhere after the commit 31bf1dbccfb0 ("bpf: Fix attaching
> fentry/fexit/fmod_ret/lsm to modules"). So we can just remove it now.
>
> Signed-off-by: Menglong Dong <dongmenglong.8@bytedance.com>
> ---
> include/linux/bpf.h | 1 -
> 1 file changed, 1 deletion(-)
Here is the summary with links:
- [bpf-next] bpf: remove unused field "mod" in struct bpf_trampoline
https://git.kernel.org/bpf/bpf-next/c/efaa47db9245
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-29 15:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-28 5:54 [PATCH bpf-next] bpf: remove unused field "mod" in struct bpf_trampoline Menglong Dong
2024-01-28 9:04 ` Jiri Olsa
2024-01-29 15:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox