From: Tejun Heo <tj@kernel.org>
To: Allen <allen.lkml@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Mikulas Patocka <mpatocka@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, dm-devel@lists.linux.dev,
Mike Snitzer <msnitzer@redhat.com>,
Ignat Korchagin <ignat@cloudflare.com>,
Damien Le Moal <damien.lemoal@wdc.com>,
Bob Liu <bob.liu@oracle.com>, Hou Tao <houtao1@huawei.com>,
Nathan Huckleberry <nhuck@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] softirq: fix memory corruption when freeing tasklet_struct
Date: Mon, 29 Jan 2024 07:06:46 -1000 [thread overview]
Message-ID: <ZbfbJuRRklWhYk4Q@slm.duckdns.org> (raw)
In-Reply-To: <CAOMdWSK5CfVpvwmCxCtYLJ-Qt+ZwhETF3K+AhNcBGtEpkKvFqg@mail.gmail.com>
Hello,
On Mon, Jan 29, 2024 at 09:00:38AM -0800, Allen wrote:
> I rushed to reply to the draft patch you sent, I should have
> looked harder. My apologies.
> The idea that I have been working on is to completely move away from
> using tasklets.
> Essentially, "get rid of tasklets entirely in the kernel". So, the use
> of tasklet_schedule() & tasklet_hi_schedule()
> will have to go.
The idea is to take over the tasklet[_hi] softirqs once all users are
converted. Otherwise, we run into the problem of setting priorities between
tasklets and the atomic workqueue, which may be a theoretical problem.
> I have a very hacky draft that is still wip. I am going to borrow
> many bits from your patch which makes
> the work I have better.
>
> Perhaps we should start a separate thread, thoughts?
Sure, please go ahead.
Thanks.
--
tejun
next prev parent reply other threads:[~2024-01-29 17:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 18:29 [PATCH] softirq: fix memory corruption when freeing tasklet_struct Mikulas Patocka
2024-01-25 19:51 ` Linus Torvalds
2024-01-25 22:04 ` Mikulas Patocka
2024-01-25 23:15 ` Damien Le Moal
2024-01-26 6:56 ` Hannes Reinecke
2024-01-26 18:09 ` Mikulas Patocka
2024-01-25 22:51 ` Ignat Korchagin
2024-01-26 0:33 ` Tejun Heo
2024-01-26 18:36 ` Allen
2024-01-26 23:43 ` Tejun Heo
2024-01-27 3:13 ` Allen
2024-01-27 18:37 ` Tejun Heo
2024-01-30 9:19 ` Tejun Heo
2024-01-29 17:00 ` Allen
2024-01-29 17:06 ` Tejun Heo [this message]
2024-04-09 14:15 ` Li Lingfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbfbJuRRklWhYk4Q@slm.duckdns.org \
--to=tj@kernel.org \
--cc=allen.lkml@gmail.com \
--cc=bob.liu@oracle.com \
--cc=damien.lemoal@wdc.com \
--cc=dm-devel@lists.linux.dev \
--cc=houtao1@huawei.com \
--cc=ignat@cloudflare.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mpatocka@redhat.com \
--cc=msnitzer@redhat.com \
--cc=nhuck@google.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox