public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Lai Jiangshan <jiangshanlai@gmail.com>
Cc: linux-kernel@vger.kernel.org, Naohiro.Aota@wdc.com, kernel-team@meta.com
Subject: Re: [PATCHSET v3 wq/for-6.9] workqueue: Implement system-wide max_active for unbound workqueues
Date: Mon, 29 Jan 2024 08:16:19 -1000	[thread overview]
Message-ID: <Zbfrc__7_kWow5wG@slm.duckdns.org> (raw)
In-Reply-To: <CAJhGHyDHP97ZHbDwPwhiYvBWbzvXw_UnXhPs4RRJ6nQBo3_x=Q@mail.gmail.com>

On Tue, Jan 30, 2024 at 12:07:33AM +0800, Lai Jiangshan wrote:
> Hello, Tejun
> 
> On Fri, Jan 26, 2024 at 1:06 AM Tejun Heo <tj@kernel.org> wrote:
> 
> > This patchset includes the following patches:
> >
> >  0001-workqueue-Move-pwq-max_active-to-wq-max_active.patch
> >  0002-workqueue-Factor-out-pwq_is_empty.patch
> >  0003-workqueue-Replace-pwq_activate_inactive_work-with-__.patch
> >  0004-workqueue-Move-nr_active-handling-into-helpers.patch
> >  0005-workqueue-Make-wq_adjust_max_active-round-robin-pwqs.patch
> >  0006-workqueue-RCU-protect-wq-dfl_pwq-and-implement-acces.patch
> >  0007-workqueue-Move-pwq_dec_nr_in_flight-to-the-end-of-wo.patch
> >  0008-workqueue-Introduce-struct-wq_node_nr_active.patch
> >  0009-workqueue-Implement-system-wide-nr_active-enforcemen.patch
> >  0010-tools-workqueue-wq_dump.py-Add-node_nr-max_active-du.patch
> >
> 
> I just left a small piece of comments on patch 8 and patch 9.
> After they are resolved, for patch 1-9:
> 
> Reviewed-by: Lai Jiangshan <jiangshanlai@gmail.com>

Updated 8 and 9 and applied the series to wq/for-6.9. If there are further
issues, let's address with followup patches.

Thanks a lot for all the reviews. Hopefully, this should address the
max_active issue for the long term.

-- 
tejun

      reply	other threads:[~2024-01-29 18:16 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-25 17:05 [PATCHSET v3 wq/for-6.9] workqueue: Implement system-wide max_active for unbound workqueues Tejun Heo
2024-01-25 17:05 ` [PATCH 01/10] workqueue: Move pwq->max_active to wq->max_active Tejun Heo
2024-01-25 17:05 ` [PATCH 02/10] workqueue: Factor out pwq_is_empty() Tejun Heo
2024-01-25 17:05 ` [PATCH 03/10] workqueue: Replace pwq_activate_inactive_work() with [__]pwq_activate_work() Tejun Heo
2024-01-25 17:05 ` [PATCH 04/10] workqueue: Move nr_active handling into helpers Tejun Heo
2024-01-25 17:05 ` [PATCH 05/10] workqueue: Make wq_adjust_max_active() round-robin pwqs while activating Tejun Heo
2024-01-25 17:05 ` [PATCH 06/10] workqueue: RCU protect wq->dfl_pwq and implement accessors for it Tejun Heo
2024-01-25 17:06 ` [PATCH 07/10] workqueue: Move pwq_dec_nr_in_flight() to the end of work item handling Tejun Heo
2024-01-25 17:06 ` [PATCH 08/10] workqueue: Introduce struct wq_node_nr_active Tejun Heo
2024-01-29 16:02   ` Lai Jiangshan
2024-01-29 18:14     ` [PATCH v4 " Tejun Heo
2024-01-30 18:00       ` Nathan Chancellor
2024-01-31  4:04         ` Tejun Heo
2024-01-25 17:06 ` [PATCH 09/10] workqueue: Implement system-wide nr_active enforcement for unbound workqueues Tejun Heo
2024-01-29 16:00   ` Lai Jiangshan
2024-01-29 18:14     ` [PATCH v4 " Tejun Heo
2024-01-30 22:30       ` Marek Szyprowski
2024-01-31  4:02         ` Tejun Heo
2024-01-31  4:12           ` Nathan Chancellor
2024-01-31  4:13             ` Tejun Heo
2024-01-31  4:20               ` Nathan Chancellor
2024-01-31  4:24                 ` Tejun Heo
2024-01-31  4:42                   ` Nathan Chancellor
2024-01-31  5:01                     ` Tejun Heo
2024-01-31  7:45                       ` Marek Szyprowski
2024-01-31 21:52                   ` Mark Brown
2024-01-31  5:25           ` [PATCH wq/for-6.9] workqueue: Avoid premature init of wq->node_nr_active[].max Tejun Heo
2024-01-25 17:06 ` [PATCH 10/10] tools/workqueue/wq_dump.py: Add node_nr/max_active dump Tejun Heo
2024-01-29 16:07 ` [PATCHSET v3 wq/for-6.9] workqueue: Implement system-wide max_active for unbound workqueues Lai Jiangshan
2024-01-29 18:16   ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zbfrc__7_kWow5wG@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=Naohiro.Aota@wdc.com \
    --cc=jiangshanlai@gmail.com \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox