From: Leonardo Bras <leobras@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: Leonardo Bras <leobras@redhat.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] wq: Avoid using isolated cpus' timers on unbounded queue_delayed_work
Date: Mon, 29 Jan 2024 17:54:04 -0300 [thread overview]
Message-ID: <ZbgQbOqkrWFPW0Mt@LeoBras> (raw)
In-Reply-To: <ZbgPveDBk8ysmF8a@slm.duckdns.org>
On Mon, Jan 29, 2024 at 10:51:09AM -1000, Tejun Heo wrote:
> On Mon, Jan 29, 2024 at 04:26:57PM -0300, Leonardo Bras wrote:
> > > Isn't that still the same number of add_timer[_on]() calls?
> >
> > Yeah, sorry about this, what I meant was: If we are ok on calling
> > add_timer_on() multiple times, I would rather go with the above version, as
> > I think it's better for readability.
>
> I don't know. It looks more verbose and less clear to me in that it isn't
> immediately clear that every branch ends with timer being added. But this is
> really minor, so unless you have a really strong opinion against the
> suggested structured, can we just do that?
Sure, we can go with the one you suggested.
Thanks!
Leo
>
> Thanks.
>
> --
> tejun
>
next prev parent reply other threads:[~2024-01-29 20:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 1:03 [PATCH v1 1/1] wq: Avoid using isolated cpus' timers on unbounded queue_delayed_work Leonardo Bras
2024-01-26 21:49 ` Tejun Heo
2024-01-26 22:05 ` Leonardo Bras
2024-01-29 18:18 ` Tejun Heo
2024-01-29 19:26 ` Leonardo Bras
2024-01-29 20:51 ` Tejun Heo
2024-01-29 20:54 ` Leonardo Bras [this message]
2024-01-29 21:17 ` Leonardo Bras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbgQbOqkrWFPW0Mt@LeoBras \
--to=leobras@redhat.com \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox