From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: claudiu beznea <claudiu.beznea@tuxon.dev>,
ulf.hansson@linaro.org, takeshi.saito.xv@renesas.com,
masaharu.hayakawa.ry@renesas.com,
yoshihiro.shimoda.uh@renesas.com, linux-mmc@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: Re: [PATCH v2] mmc: renesas_sdhi: Fix change point of data handling
Date: Tue, 30 Jan 2024 08:31:07 +0100 [thread overview]
Message-ID: <Zbilu9u9Z3MeeOb9@ninjato> (raw)
In-Reply-To: <ZbikovLbujyGS1ub@ninjato>
[-- Attachment #1: Type: text/plain, Size: 326 bytes --]
> But isn't it equal to the current code then? (Except for one thing: the
> smpcmp bit is only set when there is no cmd error. I need to double
> check but I think I like that.)
I double checked, I really like it. I'd just invert the logic. Pseudo
code:
if (!cmd_error)
if (SMPCMP == 0) set_bit
else
mmc_abort_tuning()
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-01-30 7:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 11:06 [PATCH v2] mmc: renesas_sdhi: Fix change point of data handling Claudiu
2024-01-17 14:06 ` Wolfram Sang
2024-01-29 10:43 ` Wolfram Sang
2024-01-29 10:55 ` Wolfram Sang
2024-01-30 7:03 ` claudiu beznea
2024-01-30 7:26 ` Wolfram Sang
2024-01-30 7:31 ` Wolfram Sang [this message]
2024-01-30 7:51 ` claudiu beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zbilu9u9Z3MeeOb9@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=masaharu.hayakawa.ry@renesas.com \
--cc=takeshi.saito.xv@renesas.com \
--cc=ulf.hansson@linaro.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox