From: Mark Rutland <mark.rutland@arm.com>
To: Kemeng Shi <shikemeng@huaweicloud.com>
Cc: catalin.marinas@arm.com, will@kernel.org, revest@chromium.org,
rostedt@goodmis.org, arnd@arndb.de, pengdonglin@sangfor.com.cn,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: make member of struct pt_regs and it's offset macro in the same order
Date: Tue, 30 Jan 2024 10:34:22 +0000 [thread overview]
Message-ID: <ZbjQrtHOvC4Igsur@FVFF77S0Q05N> (raw)
In-Reply-To: <20240130175504.106364-1-shikemeng@huaweicloud.com>
On Wed, Jan 31, 2024 at 01:55:04AM +0800, Kemeng Shi wrote:
> In struct pt_regs, member pstate is after member pc. Move offset macro
> of pstate after offset macro of pc to improve readability a little.
>
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
I think this makes sense as a trivial cleanup, so FWIW:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Mark.
> ---
> arch/arm64/kernel/asm-offsets.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/asm-offsets.c b/arch/arm64/kernel/asm-offsets.c
> index 5ff1942b04fc..865ba901c233 100644
> --- a/arch/arm64/kernel/asm-offsets.c
> +++ b/arch/arm64/kernel/asm-offsets.c
> @@ -75,8 +75,8 @@ int main(void)
> DEFINE(S_FP, offsetof(struct pt_regs, regs[29]));
> DEFINE(S_LR, offsetof(struct pt_regs, regs[30]));
> DEFINE(S_SP, offsetof(struct pt_regs, sp));
> - DEFINE(S_PSTATE, offsetof(struct pt_regs, pstate));
> DEFINE(S_PC, offsetof(struct pt_regs, pc));
> + DEFINE(S_PSTATE, offsetof(struct pt_regs, pstate));
> DEFINE(S_SYSCALLNO, offsetof(struct pt_regs, syscallno));
> DEFINE(S_SDEI_TTBR1, offsetof(struct pt_regs, sdei_ttbr1));
> DEFINE(S_PMR_SAVE, offsetof(struct pt_regs, pmr_save));
> --
> 2.30.0
>
next prev parent reply other threads:[~2024-01-30 10:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 17:55 [PATCH] arm64: make member of struct pt_regs and it's offset macro in the same order Kemeng Shi
2024-01-30 10:34 ` Mark Rutland [this message]
2024-02-22 22:05 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbjQrtHOvC4Igsur@FVFF77S0Q05N \
--to=mark.rutland@arm.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pengdonglin@sangfor.com.cn \
--cc=revest@chromium.org \
--cc=rostedt@goodmis.org \
--cc=shikemeng@huaweicloud.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox