* [PATCH] arm64: make member of struct pt_regs and it's offset macro in the same order
@ 2024-01-30 17:55 Kemeng Shi
2024-01-30 10:34 ` Mark Rutland
2024-02-22 22:05 ` Catalin Marinas
0 siblings, 2 replies; 3+ messages in thread
From: Kemeng Shi @ 2024-01-30 17:55 UTC (permalink / raw)
To: catalin.marinas, will, revest, rostedt, mark.rutland, arnd,
pengdonglin
Cc: linux-arm-kernel, linux-kernel, shikemeng
In struct pt_regs, member pstate is after member pc. Move offset macro
of pstate after offset macro of pc to improve readability a little.
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
arch/arm64/kernel/asm-offsets.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/asm-offsets.c b/arch/arm64/kernel/asm-offsets.c
index 5ff1942b04fc..865ba901c233 100644
--- a/arch/arm64/kernel/asm-offsets.c
+++ b/arch/arm64/kernel/asm-offsets.c
@@ -75,8 +75,8 @@ int main(void)
DEFINE(S_FP, offsetof(struct pt_regs, regs[29]));
DEFINE(S_LR, offsetof(struct pt_regs, regs[30]));
DEFINE(S_SP, offsetof(struct pt_regs, sp));
- DEFINE(S_PSTATE, offsetof(struct pt_regs, pstate));
DEFINE(S_PC, offsetof(struct pt_regs, pc));
+ DEFINE(S_PSTATE, offsetof(struct pt_regs, pstate));
DEFINE(S_SYSCALLNO, offsetof(struct pt_regs, syscallno));
DEFINE(S_SDEI_TTBR1, offsetof(struct pt_regs, sdei_ttbr1));
DEFINE(S_PMR_SAVE, offsetof(struct pt_regs, pmr_save));
--
2.30.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: make member of struct pt_regs and it's offset macro in the same order
2024-01-30 17:55 [PATCH] arm64: make member of struct pt_regs and it's offset macro in the same order Kemeng Shi
@ 2024-01-30 10:34 ` Mark Rutland
2024-02-22 22:05 ` Catalin Marinas
1 sibling, 0 replies; 3+ messages in thread
From: Mark Rutland @ 2024-01-30 10:34 UTC (permalink / raw)
To: Kemeng Shi
Cc: catalin.marinas, will, revest, rostedt, arnd, pengdonglin,
linux-arm-kernel, linux-kernel
On Wed, Jan 31, 2024 at 01:55:04AM +0800, Kemeng Shi wrote:
> In struct pt_regs, member pstate is after member pc. Move offset macro
> of pstate after offset macro of pc to improve readability a little.
>
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
I think this makes sense as a trivial cleanup, so FWIW:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Mark.
> ---
> arch/arm64/kernel/asm-offsets.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/asm-offsets.c b/arch/arm64/kernel/asm-offsets.c
> index 5ff1942b04fc..865ba901c233 100644
> --- a/arch/arm64/kernel/asm-offsets.c
> +++ b/arch/arm64/kernel/asm-offsets.c
> @@ -75,8 +75,8 @@ int main(void)
> DEFINE(S_FP, offsetof(struct pt_regs, regs[29]));
> DEFINE(S_LR, offsetof(struct pt_regs, regs[30]));
> DEFINE(S_SP, offsetof(struct pt_regs, sp));
> - DEFINE(S_PSTATE, offsetof(struct pt_regs, pstate));
> DEFINE(S_PC, offsetof(struct pt_regs, pc));
> + DEFINE(S_PSTATE, offsetof(struct pt_regs, pstate));
> DEFINE(S_SYSCALLNO, offsetof(struct pt_regs, syscallno));
> DEFINE(S_SDEI_TTBR1, offsetof(struct pt_regs, sdei_ttbr1));
> DEFINE(S_PMR_SAVE, offsetof(struct pt_regs, pmr_save));
> --
> 2.30.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: make member of struct pt_regs and it's offset macro in the same order
2024-01-30 17:55 [PATCH] arm64: make member of struct pt_regs and it's offset macro in the same order Kemeng Shi
2024-01-30 10:34 ` Mark Rutland
@ 2024-02-22 22:05 ` Catalin Marinas
1 sibling, 0 replies; 3+ messages in thread
From: Catalin Marinas @ 2024-02-22 22:05 UTC (permalink / raw)
To: will, revest, rostedt, mark.rutland, arnd, pengdonglin,
Kemeng Shi
Cc: linux-arm-kernel, linux-kernel
On Wed, 31 Jan 2024 01:55:04 +0800, Kemeng Shi wrote:
> In struct pt_regs, member pstate is after member pc. Move offset macro
> of pstate after offset macro of pc to improve readability a little.
>
>
Applied to arm64 (for-next/misc), thanks!
[1/1] arm64: make member of struct pt_regs and it's offset macro in the same order
https://git.kernel.org/arm64/c/58a0484eaf5e
--
Catalin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-22 22:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-30 17:55 [PATCH] arm64: make member of struct pt_regs and it's offset macro in the same order Kemeng Shi
2024-01-30 10:34 ` Mark Rutland
2024-02-22 22:05 ` Catalin Marinas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox