From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-renesas-soc@vger.kernel.org,
Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: sh-msiof: avoid integer overflow in constants
Date: Tue, 30 Jan 2024 12:26:54 +0100 [thread overview]
Message-ID: <Zbjc_p_Pin7TAHw4@ninjato> (raw)
In-Reply-To: <CAMuHMdUMeHCCiAkNyJMHTGUSTqewt=AWPUy+beA_kR26vcS8_Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 458 bytes --]
> What about unifying the individual SIFCTR_?FWM_[0-9]* definitions
> into SIFCTR_xFWM_[0-9]* instead, and using the bitfield helpers in its
> sole user?
But they don't match, so we can't unify them?
#define SIFCTR_TFWM_1 (7UL << 29) /* Transfer Request when 1 empty stage */
vs
#define SIFCTR_RFWM_1 (0 << 13) /* Transfer Request when 1 valid stages */
Also, the steps don't match (1, 4, 8, 12..) vs (1, 4, 8, 16...).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-01-30 11:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 9:40 [PATCH] spi: sh-msiof: avoid integer overflow in constants Wolfram Sang
2024-01-30 10:14 ` Geert Uytterhoeven
2024-01-30 11:26 ` Wolfram Sang [this message]
2024-01-30 11:39 ` Geert Uytterhoeven
2024-01-30 13:40 ` Wolfram Sang
2024-01-30 14:09 ` Geert Uytterhoeven
2024-01-30 19:38 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zbjc_p_Pin7TAHw4@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=broonie@kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox