From: Frederic Weisbecker <frederic@kernel.org>
To: Boqun Feng <boqun.feng@gmail.com>
Cc: linux-kernel@vger.kernel.org, rcu@vger.kernel.org,
"Paul E . McKenney" <paulmck@kernel.org>,
Neeraj Upadhyay <neeraj.iitr10@gmail.com>,
Joel Fernandes <joel@joelfernandes.org>,
Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Zqiang <qiang.zhang1211@gmail.com>
Subject: Re: [PATCH 1/8] rcu/exp: Remove full barrier upon main thread wakeup
Date: Tue, 30 Jan 2024 16:48:41 +0100 [thread overview]
Message-ID: <ZbkaWbpufZ6q-jLZ@localhost.localdomain> (raw)
In-Reply-To: <ZbkaBO99-6ZuNCcR@localhost.localdomain>
Le Tue, Jan 30, 2024 at 04:47:16PM +0100, Frederic Weisbecker a écrit :
> Le Mon, Jan 29, 2024 at 03:23:39PM -0800, Boqun Feng a écrit :
> > From: Frederic Weisbecker <frederic@kernel.org>
> >
> > When an expedited grace period is ending, care must be taken so that all
> > the quiescent states propagated up to the root are correctly ordered
> > against the wake up of the main expedited grace period workqueue.
> >
> > This ordering is already carried through the root rnp locking augmented
> > by an smp_mb__after_unlock_lock() barrier.
> >
> > Therefore the explicit smp_mb() placed before the wake up is not needed
> > and can be removed.
> >
> > Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
>
> [Offlist]
And yes that was not offlist, my fingers betrayed me!
>
> For further posting, don't forget to add your own SoB while posting patches :-)
>
> Thanks!
>
next prev parent reply other threads:[~2024-01-30 15:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 23:23 [PATCH 0/8] RCU exp updates for v6.9 Boqun Feng
2024-01-29 23:23 ` [PATCH 1/8] rcu/exp: Remove full barrier upon main thread wakeup Boqun Feng
2024-01-30 15:47 ` Frederic Weisbecker
2024-01-30 15:48 ` Frederic Weisbecker [this message]
2024-01-30 18:42 ` Boqun Feng
2024-01-29 23:23 ` [PATCH 2/8] rcu/exp: Fix RCU expedited parallel grace period kworker allocation failure recovery Boqun Feng
2024-01-29 23:23 ` [PATCH 3/8] rcu/exp: Handle RCU expedited grace period kworker allocation failure Boqun Feng
2024-01-29 23:23 ` [PATCH 4/8] rcu: s/boost_kthread_mutex/kthread_mutex Boqun Feng
2024-01-29 23:23 ` [PATCH 5/8] rcu/exp: Move expedited kthread worker creation functions above rcutree_prepare_cpu() Boqun Feng
2024-01-29 23:23 ` [PATCH 6/8] rcu/exp: Make parallel exp gp kworker per rcu node Boqun Feng
2024-01-29 23:23 ` [PATCH 7/8] rcu/exp: Handle parallel exp gp kworkers affinity Boqun Feng
2024-01-29 23:23 ` [PATCH 8/8] rcu/exp: Remove rcu_par_gp_wq Boqun Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbkaWbpufZ6q-jLZ@localhost.localdomain \
--to=frederic@kernel.org \
--cc=boqun.feng@gmail.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=neeraj.iitr10@gmail.com \
--cc=paulmck@kernel.org \
--cc=qiang.zhang1211@gmail.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox