The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Tony Luck <tony.luck@intel.com>
To: x86@kernel.org
Cc: Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
	Reinette Chatre <reinette.chatre@intel.com>,
	linux-kernel@vger.kernel.org
Subject: commit tag order vs. "b4 am"
Date: Tue, 30 Jan 2024 14:34:06 -0800	[thread overview]
Message-ID: <Zbl5XvzpqND9exmW@agluck-desk3> (raw)

Reinette noticed that v14 of my resctrl/SNC patch series[1] did not adhere
to the tag order proscribed in Documentation/process/maintainer-tip.rst
Specifically my "Signed-off-by:" was now the last tag, instead of
appearing before the "Reviewed-by:" and "Tested-by" tags as it had in
v13.

A little digging showed that my tag had been moved to the end by "b4 am"
when I used it to pick up some additonal tags.

An e-mail discussion with Konstantin ensued to determine if this was
a bug. Konstantin said:

   This is the intended behaviour, because b4 follows the chain-of-custody
   procedure. If we encounter a Signed-off-by trailer matching the identity of
   the user preparing the series, we move it to the bottom to indicate that the
   chain-of-custody boundary has moved to include the code review trailers
   received after the initial submission.

   https://lore.kernel.org/tools/20221031165842.vxr4kp6h7qnkc53l@meerkat.local/

   Basically, the "Signed-off-by" trailer is special because it indicates that
   everything above it is the responsibility of the person doing the sign-off. If
   we kept your Signed-off-by in the original spot, then it wouldn't be clear who
   collected and applied the trailers.

Question: Do the TIP maintainers agree with Konstantin's opinion that
the Signed-off-by: includes all the tags applied prior? If so, this
should be called out in Documentation/process/maintainer-tip.rst


[1] https://lore.kernel.org/all/20240126223837.21835-1-tony.luck@intel.com/

             reply	other threads:[~2024-01-30 22:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-30 22:34 Tony Luck [this message]
2024-01-31  0:47 ` commit tag order vs. "b4 am" Randy Dunlap
2024-01-31  1:57   ` Konstantin Ryabitsev
2024-01-31  3:20     ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zbl5XvzpqND9exmW@agluck-desk3 \
    --to=tony.luck@intel.com \
    --cc=konstantin@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=reinette.chatre@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox