Re: [PATCH 1/3] selftests: zswap: add zswap selftest file to zswap maintainer entry

Nhat Pham
2024-01-30T18:37:26Z

On Mon, Jan 29, 2024 at 5:02 PM Yosry Ahmed <yosryahmed@google.com> wrote:
>
> On Mon, Jan 29, 2024 at 02:45:40PM -0800, Nhat Pham wrote:
> > Make it easier for contributors to find the zswap maintainers when they
> > update the zswap tests.
> >
> > Signed-off-by: Nhat Pham <nphamcs@gmail.com>
>
> I guess I had to check the zswap tests at some point :)

We sorely need more zswap tests :)

I'm one of the offenders of adding new features without including
tests, so no judging anyone of course, and admittedly zswap is quite
intertwined with other parts of MM, so it's kinda hard to write
unit-ish tests for zswap only. I often had to resort to scripting
stress tests to iron out bugs.

But there are still tests that we can write to verify public API
(cgroup's zswap options come to mind), simple tests that cover crucial
code paths, etc. that we should probably add in. At the very least
this can be a quick/sanity check for developing and backporting
patches into the production system.

>
> Acked-by: Yosry Ahmed <yosryahmed@google.com>
>
> > ---
> > MAINTAINERS | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index fecebfc4c0dc..5f60faaefaf2 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -24396,6 +24396,7 @@ F: include/linux/zpool.h
> > F: include/linux/zswap.h
> > F: mm/zpool.c
> > F: mm/zswap.c
> > +F: tools/testing/selftests/cgroup/test_zswap.c
> >
> > THE REST
> > M: Linus Torvalds <torvalds@linux-foundation.org>
> > --
> > 2.39.3
> >