From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26DB77EF06; Tue, 30 Jan 2024 23:01:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706655693; cv=none; b=O2p8wKuQsIBEbglnWyhtTaTr2l65jvfdeZB/1xeMuSn/ttExredTjEM5b4oO5If91IVvWRV8dNd2CoPCXTKdq7HSB99XLSyrsbn/3mZwJezhnY7iiOjSab0MUIDRte3TjRd5/a2l5OlIk6qkOsfSwHJlcDI2wlH14MaNR7y8zeI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706655693; c=relaxed/simple; bh=ku1C/ZkbKX+29BRUe76r+E2vI8ZO7+6hPMyFCOiFLQQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FiizZ2rotWRU+zfJ/KgqSuBZ1NSw+erq9SNQtm/OY0aYGZ1RokU0ENAeZ16REWD5kVooijriEEhAsDQkHoPCFQcc4NqCdLj8Z1ntNhHVfRj0agvFrLmPlj3Zw7lA2nZkvjmAkNTJSTF5PMhapEjYzL5RIQrI/YyvRywluXqF5eY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=D/4bDsru; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="D/4bDsru" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 673B8C433C7; Tue, 30 Jan 2024 23:01:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706655692; bh=ku1C/ZkbKX+29BRUe76r+E2vI8ZO7+6hPMyFCOiFLQQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D/4bDsruR054m2eZrmHx9bopxrE7FZ6qZLIETLGBtVSr1Klv3+vKCOGaLfD09IpK0 QLusj9nMEU2zhFJOCloZsME3p6H6Spz5WOKFVCxl3P3/ZD2H9x12Tqj3rTiVKWKRd8 lZcWgUru/vix1hPpGdIJ8NB73EQt/naxYOkPhg9bAhHsCXkCvNvQE0rhZ42ClEKlc/ Lu1RKry+swCBJqxifi5fcxiNo+WLIg57pt+r1SmviioOBT8i+25XBxjwyYctAkG/1q HxUkrLvVa5R9Yv6kyWTpej5genuaZfEIr/1QucvIONqt0EouWdoMwzyDTFRJFrK2ac 6OCK/MK1Kl7YQ== Date: Tue, 30 Jan 2024 18:01:31 -0500 From: Sasha Levin To: Sebastian Reichel Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Konrad Dybcio , Luca Weiss , andersson@kernel.org, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, Johan Hovold Subject: Re: [PATCH AUTOSEL 6.7 15/39] power: supply: qcom_battmgr: Register the power supplies after PDR is up Message-ID: References: <20240128161130.200783-1-sashal@kernel.org> <20240128161130.200783-15-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: On Mon, Jan 29, 2024 at 02:03:14PM +0100, Sebastian Reichel wrote: >Hi, > >On Sun, Jan 28, 2024 at 11:10:35AM -0500, Sasha Levin wrote: >> From: Konrad Dybcio >> >> [ Upstream commit b43f7ddc2b7a5a90447d96cb4d3c6d142dd4a810 ] >> >> Currently, a not-yet-entirely-initialized battmgr (e.g. with pd-mapper >> not having yet started or ADSP not being up etc.) results in a couple of >> zombie power supply devices hanging around. >> >> This is particularly noticeable when trying to suspend the device (even >> s2idle): the PSY-internal thermal zone is inaccessible and returns >> -ENODEV, which causes log spam. >> >> Register the power supplies only after we received some notification >> indicating battmgr is ready to take off. >> >> Signed-off-by: Konrad Dybcio >> Tested-by: Luca Weiss >> Link: https://lore.kernel.org/r/20231218-topic-battmgr_fixture_attempt-v1-1-6145745f34fe@linaro.org >> Signed-off-by: Sebastian Reichel >> Signed-off-by: Sasha Levin >> --- > >Please drop it, I have a patch queued reverting this patch. Dropped, thanks! -- Thanks, Sasha