From: Jiri Pirko <jiri@resnulli.us>
To: karthiksundaravel <ksundara@redhat.com>
Cc: jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
rjarry@redhat.com, aharivel@redhat.com, vchundur@redhat.com,
cfontain@redhat.com
Subject: Re: [PATCH] ice: Add get/set hw address for VF representor ports
Date: Wed, 31 Jan 2024 09:55:17 +0100 [thread overview]
Message-ID: <ZboK9aHNTngj71ue@nanopsycho> (raw)
In-Reply-To: <20240131080847.30614-1-ksundara@redhat.com>
Wed, Jan 31, 2024 at 09:08:47AM CET, ksundara@redhat.com wrote:
>Changing the mac address of the VF representor ports are not
>available via devlink. Add the function handlers to set and get
>the HW address for the VF representor ports.
Wait a sec. The API is there to change the mac of the actual VF. Not the
representor. Apparently your patch is not doing that, changing mac of
the representor.
NAK.
Fix this to change the VF mac address or drop the patch entirely.
Thanks!
pw-bot: cr
next prev parent reply other threads:[~2024-01-31 8:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 8:08 [PATCH] ice: Add get/set hw address for VF representor ports karthiksundaravel
2024-01-31 8:55 ` Jiri Pirko [this message]
2024-01-31 10:43 ` Michal Swiatkowski
2024-01-31 12:00 ` Jiri Pirko
2024-02-01 6:55 ` Michal Swiatkowski
2024-01-31 16:15 ` [Intel-wired-lan] " Paul Menzel
2024-02-01 7:40 ` Jiri Pirko
2024-02-01 8:00 ` Paul Menzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZboK9aHNTngj71ue@nanopsycho \
--to=jiri@resnulli.us \
--cc=aharivel@redhat.com \
--cc=anthony.l.nguyen@intel.com \
--cc=cfontain@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=ksundara@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rjarry@redhat.com \
--cc=vchundur@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox