From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mike Looijmans <mike.looijmans@topic.nl>
Cc: devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
"Arnd Bergmann" <arnd@arndb.de>,
"Haibo Chen" <haibo.chen@nxp.com>,
"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Lee Jones" <lee@kernel.org>,
"Leonard Göhrs" <l.goehrs@pengutronix.de>,
"Liam Beguin" <liambeguin@gmail.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Maksim Kiselev" <bigunclemax@gmail.com>,
"Marcus Folkesson" <marcus.folkesson@gmail.com>,
"Marius Cristea" <marius.cristea@microchip.com>,
"Mark Brown" <broonie@kernel.org>,
"Niklas Schnelle" <schnelle@linux.ibm.com>,
"Okan Sahin" <okan.sahin@analog.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: adc: ti-ads1298: Add driver
Date: Thu, 1 Feb 2024 13:38:16 +0200 [thread overview]
Message-ID: <ZbuCqEWqpDadeF_v@smile.fi.intel.com> (raw)
In-Reply-To: <406d445a-3ce3-4253-8966-de2dac6f7c23@topic.nl>
On Wed, Jan 31, 2024 at 05:10:08PM +0100, Mike Looijmans wrote:
> On 13-12-2023 15:55, Andy Shevchenko wrote:
> > On Wed, Dec 13, 2023 at 10:47:22AM +0100, Mike Looijmans wrote:
First of all, please remove unneeded context, don't make me waste time on doing
that for you!
...
> > *val = sign_extend32(get_unaligned_be24(priv->rx_buffer + chan->address),
> > 23);
>
> Doesn't fit, first line is 83 characters by my count...
Is it a problem?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-02-01 12:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.618139b3-8cb2-4e4c-9283-9e3787c70105@emailsignatures365.codetwo.com>
2023-12-13 9:47 ` [PATCH 1/2] dt-bindings: iio: adc: ti-ads1298: Add driver Mike Looijmans
2023-12-13 9:47 ` [PATCH 2/2] " Mike Looijmans
2023-12-13 14:55 ` Andy Shevchenko
2024-01-31 16:10 ` Mike Looijmans
2024-02-01 11:38 ` Andy Shevchenko [this message]
2024-02-04 13:06 ` Jonathan Cameron
2023-12-14 11:06 ` Jonathan Cameron
2024-01-31 16:24 ` Mike Looijmans
2024-02-04 13:32 ` Jonathan Cameron
2023-12-13 16:23 ` [PATCH 1/2] dt-bindings: " Conor Dooley
2023-12-14 10:22 ` Jonathan Cameron
2023-12-20 10:42 ` Mike Looijmans
2023-12-20 13:59 ` Jonathan Cameron
2023-12-14 11:11 ` Jonathan Cameron
2023-12-20 10:58 ` Mike Looijmans
2023-12-20 14:00 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbuCqEWqpDadeF_v@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bigunclemax@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=haibo.chen@nxp.com \
--cc=hvilleneuve@dimonoff.com \
--cc=jic23@kernel.org \
--cc=l.goehrs@pengutronix.de \
--cc=lars@metafoo.de \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=liambeguin@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcus.folkesson@gmail.com \
--cc=marius.cristea@microchip.com \
--cc=mike.looijmans@topic.nl \
--cc=okan.sahin@analog.com \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox