From: Jiri Pirko <jiri@resnulli.us>
To: Ivan Vecera <ivecera@redhat.com>
Cc: netdev@vger.kernel.org, Egor Pomozov <epomozov@marvell.com>,
Igor Russkikh <irusskikh@marvell.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
Dmitry Bezrukov <dmitry.bezrukov@aquantia.com>,
Sergey Samoilenko <sergey.samoilenko@aquantia.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: atlantic: Fix DMA mapping for PTP hwts ring
Date: Thu, 1 Feb 2024 13:39:03 +0100 [thread overview]
Message-ID: <ZbuQ58l4DoWU70Bp@nanopsycho> (raw)
In-Reply-To: <20240201094752.883026-1-ivecera@redhat.com>
Thu, Feb 01, 2024 at 10:47:51AM CET, ivecera@redhat.com wrote:
>Function aq_ring_hwts_rx_alloc() maps extra AQ_CFG_RXDS_DEF bytes
>for PTP HWTS ring but then generic aq_ring_free() does not take this
>into account.
>Create and use a specific function to free HWTS ring to fix this
>issue.
>
>Trace:
>[ 215.351607] ------------[ cut here ]------------
>[ 215.351612] DMA-API: atlantic 0000:4b:00.0: device driver frees DMA memory with different size [device address=0x00000000fbdd0000] [map size=34816 bytes] [unmap size=32768 bytes]
>[ 215.351635] WARNING: CPU: 33 PID: 10759 at kernel/dma/debug.c:988 check_unmap+0xa6f/0x2360
>...
>[ 215.581176] Call Trace:
>[ 215.583632] <TASK>
>[ 215.585745] ? show_trace_log_lvl+0x1c4/0x2df
>[ 215.590114] ? show_trace_log_lvl+0x1c4/0x2df
>[ 215.594497] ? debug_dma_free_coherent+0x196/0x210
>[ 215.599305] ? check_unmap+0xa6f/0x2360
>[ 215.603147] ? __warn+0xca/0x1d0
>[ 215.606391] ? check_unmap+0xa6f/0x2360
>[ 215.610237] ? report_bug+0x1ef/0x370
>[ 215.613921] ? handle_bug+0x3c/0x70
>[ 215.617423] ? exc_invalid_op+0x14/0x50
>[ 215.621269] ? asm_exc_invalid_op+0x16/0x20
>[ 215.625480] ? check_unmap+0xa6f/0x2360
>[ 215.629331] ? mark_lock.part.0+0xca/0xa40
>[ 215.633445] debug_dma_free_coherent+0x196/0x210
>[ 215.638079] ? __pfx_debug_dma_free_coherent+0x10/0x10
>[ 215.643242] ? slab_free_freelist_hook+0x11d/0x1d0
>[ 215.648060] dma_free_attrs+0x6d/0x130
>[ 215.651834] aq_ring_free+0x193/0x290 [atlantic]
>[ 215.656487] aq_ptp_ring_free+0x67/0x110 [atlantic]
>...
>[ 216.127540] ---[ end trace 6467e5964dd2640b ]---
>[ 216.132160] DMA-API: Mapped at:
>[ 216.132162] debug_dma_alloc_coherent+0x66/0x2f0
>[ 216.132165] dma_alloc_attrs+0xf5/0x1b0
>[ 216.132168] aq_ring_hwts_rx_alloc+0x150/0x1f0 [atlantic]
>[ 216.132193] aq_ptp_ring_alloc+0x1bb/0x540 [atlantic]
>[ 216.132213] aq_nic_init+0x4a1/0x760 [atlantic]
>
>Fixes: 94ad94558b0f ("net: aquantia: add PTP rings infrastructure")
>Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
next prev parent reply other threads:[~2024-02-01 12:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 9:47 [PATCH net] net: atlantic: Fix DMA mapping for PTP hwts ring Ivan Vecera
2024-02-01 12:39 ` Jiri Pirko [this message]
2024-02-03 4:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbuQ58l4DoWU70Bp@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=dmitry.bezrukov@aquantia.com \
--cc=edumazet@google.com \
--cc=epomozov@marvell.com \
--cc=irusskikh@marvell.com \
--cc=ivecera@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=sergey.samoilenko@aquantia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox