From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0BE04C3B3 for ; Fri, 2 Feb 2024 08:15:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.198 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706861721; cv=none; b=s6mLHRAxkaoMRAlxbb9Ix0GHTIGQk/2u8zbtMzseUvxUzb+RqKvqYQ1sVUr9RHH+FZ4PPOO8QvJnDLSAr9vxvYmpSBleZibuAAPctrXwHXKbQF/Hi8JfNXkIDmT6u6OxNlrzCpOWNnW+zVEiPTCGP59aA2evLJCtz1vpEqp6a8k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706861721; c=relaxed/simple; bh=22KrYw6AGbOORrKGF2dfcOeS42CZyhRN03F+KeITbCc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=m3vh69XY3HkrFd/SngadkEuDxPQzxy1Hr1vtkpnJDMw1EPjNG+FJdox8TwEBiNKF2+2mXG8SV9SKN4wBynlCwpyFmWo53VgQR0FoE6EsMXGjAn+iRkDesrbK5FYw4DTmQEn8bKI5jkeRXBws9BFKaOWPfrfNt/Z3d+N5vxEyU40= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=nbkCFvYx; arc=none smtp.client-ip=217.70.183.198 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="nbkCFvYx" Received: by mail.gandi.net (Postfix) with ESMTPSA id 10238C000C; Fri, 2 Feb 2024 08:15:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1706861711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IELpse5tL7jxLQ50n/erAXQJmF3PhIHOp+iVjw6RjuA=; b=nbkCFvYx/0abOwR4f/l/xf/UAj+v47faf2e5yKK6aMe6eNo8sAKnNA6wOuL1e+J68SjOHx VT3eAHbcH7rG34TCFkZfpeizDKFXzU9k5T3PoWaltYntFjU0gTVTgNGpxmln5Gy+sMlRf/ 3Xg9uBkPZkmftuenYCmNSyiDB6ajEXIPGhYb8CpQugEU4klP6io8HmlJfLR0cNB03ZrRKL IpNIrDSEQw6DihD0PesQ9VBWI0r6w77qUybXlSWYp9FrCjj/1+zPH9zi0V6CmZF1hVDsw4 QYX6paApyTwAwt1W1e325ML5/geNrxOqzVrjTsDPfADU1KVrmwYId3E9V0WLrg== Date: Fri, 2 Feb 2024 09:15:07 +0100 From: Louis Chauvet To: Maira Canal Cc: Rodrigo Siqueira , Melissa Wen , =?iso-8859-1?Q?Ma=EDra?= Canal , Haneen Mohammed , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , marcheu@google.com, seanpaul@google.com, nicolejadeyee@google.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, miquel.raynal@bootlin.com Subject: Re: [PATCH 0/2] Better support for complex pixel formats Message-ID: Mail-Followup-To: Maira Canal , Rodrigo Siqueira , Melissa Wen , =?iso-8859-1?Q?Ma=EDra?= Canal , Haneen Mohammed , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , marcheu@google.com, seanpaul@google.com, nicolejadeyee@google.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, miquel.raynal@bootlin.com References: <20240201-yuv-v1-0-3ca376f27632@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-GND-Sasl: louis.chauvet@bootlin.com Le 01/02/24 - 19:07, Maira Canal a écrit : > Hi Louis, > > Thanks for your patches! Could you please rebase them on top of > drm-misc-next? It would make it easier for me to review and test the > patches. > > Best Regards, > - Maíra Hi Maíra, Do you want me to rebase the whole YUV [1] series or should I extract and make my two patches independent? [1]: https://lore.kernel.org/dri-devel/20240110-vkms-yuv-v2-0-952fcaa5a193@riseup.net/ Best regards, Louis Chauvet > On 2/1/24 14:31, Louis Chauvet wrote: > > This patchset aims to solve issues I found in [1], and at the same time > > simplify the composition algorithm. > > > > I sent more igt-gpu-tools test [2] to cover more things and detect the > > issues in [1]. > > > > This patchset is based on [1]. > > > > Patch 1/2: This patch is a no-op, but make the code more readable > > regarding the pixel_read functions. > > > > Patch 2/2: This patch is more complex. My main target was to solve issues > > I found in [1], but as it was very complex to do it "in place", I choose > > to rework the composition function. > > The main two advantages are: > > - It's now possible to create conversion function for packed & grouped > > pixels. Some pixel formats need absolute x/y position and not only an > > offset in the buffer to extract the correct value. This part also solve > > the issues I found in [1]. > > - The rotation management is now way easier to understand, there is no > > more switch case in different places and instead of copy/pasting rotation > > formula I used drm_rect_* helpers. > > > > [1]: https://lore.kernel.org/dri-devel/20240110-vkms-yuv-v2-0-952fcaa5a193@riseup.net/ > > [2]: https://lore.kernel.org/igt-dev/20240201-kms_tests-v1-0-bc34c5d28b3f@bootlin.com/T/#t > > > > Signed-off-by: Louis Chauvet > > --- > > Louis Chauvet (2): > > drm/vkms: Create a type to check a function pointer validity > > drm/vkms: Use a simpler composition function > > > > drivers/gpu/drm/vkms/vkms_composer.c | 97 ++++++++----- > > drivers/gpu/drm/vkms/vkms_drv.h | 32 ++++- > > drivers/gpu/drm/vkms/vkms_formats.c | 254 ++++++++++++++++++----------------- > > drivers/gpu/drm/vkms/vkms_formats.h | 2 +- > > drivers/gpu/drm/vkms/vkms_plane.c | 13 +- > > 5 files changed, 236 insertions(+), 162 deletions(-) > > --- > > base-commit: 5d189d57bb335a87ec38ea26fe43a5f3ed31ced7 > > change-id: 20240201-yuv-1337d90d9576 > > > > Best regards,