From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 466E58005A for ; Fri, 2 Feb 2024 10:31:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706869898; cv=none; b=qpsaNyv+Wfm1AfPBjGk7tRm3wIecjNlrsfBGJTi/mE/rCTX9jxTyBbfv24ubHU0K6nZnYRx8niypdJs4Og3lwPrsMB+a+aORgWdMapRm4XKTGiXeFBSTF0uDnGZZeP8s8o5E2CEHJkBirnJyh8RE8jsdvAbyIFwj8lwu5RO5fTE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706869898; c=relaxed/simple; bh=9tCuWptXmQTXPVjGPkphoVl54eQWHUAdfFKj08Jj3Ro=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GXz7Oht17aeIM88hpTnvC1F1Xinhf+eUXK11i116bvIWPV2p0osB3Y6bZDO9OFjLvwryqo7fvxPUJCicSLAb83fOkCuu/7X2vAxCLClm8Ryp+N1fcIVYvonZ7dro3mNr3CnLgcrKTbKU0irzR4m7dkjxIvIdPk3KSx0Zvq2/lUU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yWkIHjk5; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yWkIHjk5" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a26f73732c5so298626966b.3 for ; Fri, 02 Feb 2024 02:31:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706869894; x=1707474694; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=TEMqIdmulKhVsjdY20YuljLXuh2/LBX4s4/zE5sYM8o=; b=yWkIHjk5w42G1tS6oYex+mk2hXbi/fqqS7EIOq8v/K0HB8clYuAJ2kzqYHy1EINupx JGLgIdLgH5rF+9DmfUWtr5UyRtohTaJvv0PPhzf8prWOOEV0vCbUfu1DnD5e4FQFD6Z1 yFFHYbhZ5eBa1ZvsYAezPc8lIXS8+sSICqlIgU+8RQ299Vkt0uCzXyZQc43pSx6HzzCC Z5dnz6Lp2mNdWCEA358ORnJJWoK0ccfpU2ACuZ8UDEQ91GE+/cFUYo1rgnqmJMSvgXWX YlAoHRwrbjDsduOwUDXMohUZjK+Y7yt22S76obK+cxmdZivOmCkvcDYRTV8zgixdBqtg 7O1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706869894; x=1707474694; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TEMqIdmulKhVsjdY20YuljLXuh2/LBX4s4/zE5sYM8o=; b=cxmUc62ykTrMZv6dObjC2i+EdCNVBkJXn8h1udXLCAP5vha3252UnWJFTc79oM2nNv g1JV2FoAa23HgFmAWYHTEQD+MJ2VQdVZNmTj7lVd1mt/GfVmlkLbqObdp46r37gMNWic 45uY8O5iGutajlg7xKQ8uIk2epPgannMjtmhS5NfF++qN5s1iTfC1c66ywDnRni1atun DX6Wtz7CLtkiPNEcqbCt8p6YID0zk7F0sFIpfe8Z9SZXOY78p7qwKuIu5qBtSRpgZr70 jpVezy/e5ldLCtKj9fw0Ak81wWk+rZdeYIQ7Y+YOubb9UOQxdWmCowtyBnNzyvw/PzT1 14xg== X-Gm-Message-State: AOJu0Yywzu5Cv4pTzuZ2kSkm0lY9z3dSP25S6DHb7sijZ1VK31YAQNRv tXkcjXqxDL6fwjMv4Rf7ruM0QuIWhRTqQU17si0HbMfhl3eVi98HjcJTvYFy+n4= X-Google-Smtp-Source: AGHT+IEHCLOqEe6ybJMe/egvvzUwDgL42WplE40d7hX687OcUa0bqRXLi7rRtnP4KP8+P0IFShaplg== X-Received: by 2002:a17:906:754:b0:a35:d2f8:4927 with SMTP id z20-20020a170906075400b00a35d2f84927mr3388960ejb.70.1706869894340; Fri, 02 Feb 2024 02:31:34 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXtZKiMJreSxrgd3PdyMOjnQWK0Q8zEmnM9aJHlnfrlvcPypomiCWFQyH80Cf9EhBrgPu1clIIW8QqGoOfArEfVXCTymBaMn4MOSuJTWNUorybzpT/d6kfIhYkDusPmSIBRX5aPbGnMbJeJjDc9VDBLXwgNOJRBUKuoc7e9JX50aFpj7LOBIqDm/MyCanklSMZPxI77jajw+5LP1ZM1MhuONa6BHtSwH6+0GoLfoxoxnFt0BVsIZ+Amgi3qVBEqmP0VKpsUh0LkHLT0h6cgCHU+anj3q4SmvW2f0VhXf/ocSJ3NSqFg2xrOqCwCI3OodkUDir/s7fKd+tbUZGs4BTO47A== Received: from linaro.org ([62.231.97.49]) by smtp.gmail.com with ESMTPSA id rf14-20020a1709076a0e00b00a371c568978sm216622ejc.150.2024.02.02.02.31.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 02:31:33 -0800 (PST) Date: Fri, 2 Feb 2024 12:31:32 +0200 From: Abel Vesa To: Manivannan Sadhasivam Cc: neil.armstrong@linaro.org, Konrad Dybcio , Bjorn Andersson , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] PCI: qcom: Add X1E80100 PCIe support Message-ID: References: <20240129-x1e80100-pci-v2-0-a466d10685b6@linaro.org> <20240129-x1e80100-pci-v2-2-a466d10685b6@linaro.org> <30360d96-4513-40c4-9646-e3ae09121fa7@linaro.org> <20240202084157.GE2961@thinkpad> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240202084157.GE2961@thinkpad> On 24-02-02 14:11:57, Manivannan Sadhasivam wrote: > On Fri, Feb 02, 2024 at 09:13:25AM +0100, neil.armstrong@linaro.org wrote: > > On 01/02/2024 20:20, Konrad Dybcio wrote: > > > On 29.01.2024 12:10, Abel Vesa wrote: > > > > Add the compatible and the driver data for X1E80100. > > > > > > > > Signed-off-by: Abel Vesa > > > > --- > > > > drivers/pci/controller/dwc/pcie-qcom.c | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > > > > index 10f2d0bb86be..2a6000e457bc 100644 > > > > --- a/drivers/pci/controller/dwc/pcie-qcom.c > > > > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > > > > @@ -1642,6 +1642,7 @@ static const struct of_device_id qcom_pcie_match[] = { > > > > { .compatible = "qcom,pcie-sm8450-pcie0", .data = &cfg_1_9_0 }, > > > > { .compatible = "qcom,pcie-sm8450-pcie1", .data = &cfg_1_9_0 }, > > > > { .compatible = "qcom,pcie-sm8550", .data = &cfg_1_9_0 }, > > > > + { .compatible = "qcom,pcie-x1e80100", .data = &cfg_1_9_0 }, > > > > > > I swear I'm not delaying everything related to x1 on purpose.. > > > > > > But.. > > > > > > Would a "qcom,pcie-v1.9.0" generic match string be a good idea? > > > > Yes as fallback, this is why I used qcom,pcie-sm8550 as fallback for SM8650. > > > > Right. Fallback should be used here also. So after digging a bit more ... Nope. Fallback approach doesn't work for X1E80100. The ddrss_sf_qtb clock is, on this platform, under RPMH control, and therefore not registered by the GCC. This implies this clock cannot be provided to the pcie controller node in DT, which implies the bindings are different when compared to sm8550. So dedicated compatible is needed. So this patchset should remain as is. > > - Mani > > -- > மணிவண்ணன் சதாசிவம்