From: Andrea Parri <parri.andrea@gmail.com>
To: Eric Chan <ericchancf@google.com>
Cc: paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/4] riscv/barrier: Define __{mb,rmb,wmb}
Date: Fri, 16 Feb 2024 21:30:22 +0100 [thread overview]
Message-ID: <Zc/F3qB8I+AaN9Wr@andrea> (raw)
In-Reply-To: <20240213223909.2596587-1-ericchancf@google.com>
On Tue, Feb 13, 2024 at 10:39:09PM +0000, Eric Chan wrote:
> Introduce __{mb,rmb,wmb}, and rely on the generic definitions for
> {mb,rmb,wmb}. Although KCSAN is not yet support, it can be made more
supported, the code/definitions
> -#define mb() RISCV_FENCE(iorw,iorw)
> -#define rmb() RISCV_FENCE(ir,ir)
> -#define wmb() RISCV_FENCE(ow,ow)
> +#define __mb() RISCV_FENCE(iorw,iorw)
> +#define __rmb() RISCV_FENCE(ir,ir)
> +#define __wmb() RISCV_FENCE(ow,ow)
It seems you forgot to apply Emil's suggestion from v3; please do in v6.
(No need to do something immediately, still reviewing this version. ;))
Andrea
next prev parent reply other threads:[~2024-02-16 20:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 22:38 [PATCH v5 0/4] riscv/barrier: tidying up barrier-related macro Eric Chan
2024-02-13 22:39 ` [PATCH v5 1/4] riscv/barrier: Define __{mb,rmb,wmb} Eric Chan
2024-02-16 20:30 ` Andrea Parri [this message]
2024-02-13 22:39 ` [PATCH v5 2/4] riscv/barrier: Define RISCV_FULL_BARRIER Eric Chan
2024-02-13 22:39 ` [PATCH v5 3/4] riscv/barrier: Consolidate fence definitions Eric Chan
2024-02-13 22:40 ` [PATCH v5 4/4] riscv/barrier: Resolve checkpatch.pl error Eric Chan
2024-02-16 21:05 ` Andrea Parri
2024-02-17 13:07 ` Eric Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zc/F3qB8I+AaN9Wr@andrea \
--to=parri.andrea@gmail.com \
--cc=aou@eecs.berkeley.edu \
--cc=ericchancf@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox